Skip to content

Remove gobierto dashboards #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
entantoencuanto wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Remove gobierto dashboards #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44776e6
Delete gobierto dashboards models, controllers, serializers, views an…
entantoencuanto Sep 9, 2021
981e62a
Define engine_modules in application config to be managed by external…
entantoencuanto Sep 10, 2021
5a874a7
Check if dashboards model is defined
entantoencuanto Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions app/controllers/gobierto_admin/gobierto_dashboards/dashboards_controller.rb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion app/controllers/gobierto_admin/gobierto_plans/projects_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def find_versioned_project
end

def set_dashboards_list_path
return unless current_site.configuration.gobierto_dashboards_enabled? &&
return unless current_site.configuration.available_module?("GobiertoDashboards") &&
current_admin.module_allowed_action?(current_admin_module, current_site, :manage_dashboards)

@dashboards_list_path ||= list_admin_plans_plan_dashboards_path(@plan)
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/gobierto_admin/sites_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def find_site
end

def get_site_modules
APP_CONFIG[:site_modules].map { |site_module| OpenStruct.new(site_module) }
APP_CONFIG[:site_modules].union(Rails.configuration.engine_modules).map { |site_module| OpenStruct.new(site_module) }
end

def set_auth_modules
Expand Down
13 changes: 0 additions & 13 deletions app/controllers/gobierto_dashboards/api/v1/base_controller.rb
View file
Open in desktop

This file was deleted.

152 changes: 0 additions & 152 deletions app/controllers/gobierto_dashboards/api/v1/dashboards_controller.rb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion app/controllers/gobierto_plans/plan_types_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def sdg
private

def dashboards_enabled?
@dashboards_enabled ||= module_enabled?("GobiertoDashboards") && current_site.dashboards.active.for_context(@plan).exists?
@dashboards_enabled ||= module_enabled?("GobiertoDashboards") && defined?(GobiertoDashboards::Dashboard) && current_site.dashboards.active.for_context(@plan).exists?
end

def find_plan_type
Expand Down
118 changes: 0 additions & 118 deletions app/forms/gobierto_dashboards/dashboard_form.rb
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions app/models/gobierto_dashboards/dashboard.rb
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions app/models/gobierto_dashboards/data_pipes/base.rb
View file
Open in desktop

This file was deleted.

Loading