Merge pull request #113 from GoodOlClint/BugFixes

Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions

Author: yutingc

Rules/ProvideVerboseMessage.cs

@@ -12,10 +12,12 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.Powershell.ScriptAnalyzer.Generic;
 using System.ComponentModel.Composition;
 using System.Globalization;
+using System.Management.Automation;
 
 namespace Microsoft.Windows.Powershell.ScriptAnalyzer.BuiltinRules
 {
@@ -57,6 +59,15 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
                 return AstVisitAction.SkipChildren;
             }
 
+            //Write-Verbose is not required for non-advanced functions
+            if (funcAst.Body == null || funcAst.Body.ParamBlock == null
+           || funcAst.Body.ParamBlock.Attributes == null ||
+           funcAst.Body.ParamBlock.Parameters == null ||
+                !funcAst.Body.ParamBlock.Attributes.Any(attr => attr.TypeName.GetReflectionType() == typeof(CmdletBindingAttribute)))
+            {
+                return AstVisitAction.Continue;
+            }
+
             var commandAsts = funcAst.Body.FindAll(testAst => testAst is CommandAst, false);
             bool hasVerbose = false;
 

Tests/Rules/GoodCmdlet.ps1

@@ -81,4 +81,10 @@ function Get-File
         if ($pscmdlet.ShouldContinue("Yes", "No")) {
         }
     }
+}
+
+#Write-Verbose should not be required because this is not an advanced function
+function Get-SimpleFunc
+{
+
 }