Fix rule suppression does not work when the one of the value is null

Author: Quoc Truong

Engine/Generic/RuleSuppression.cs

@@ -57,7 +57,9 @@ public string RuleName
             set
             {
                 _ruleName = value;
-                if ((ScriptAnalyzer.Instance.ScriptRules != null
+
+                if (!String.IsNullOrWhiteSpace(_ruleName)
+                    && (ScriptAnalyzer.Instance.ScriptRules != null
                         && ScriptAnalyzer.Instance.ScriptRules.Count(item => String.Equals(item.GetName(), _ruleName, StringComparison.OrdinalIgnoreCase)) == 0)
                     && (ScriptAnalyzer.Instance.TokenRules != null
                         && ScriptAnalyzer.Instance.TokenRules.Count(item => String.Equals(item.GetName(), _ruleName, StringComparison.OrdinalIgnoreCase)) == 0)
@@ -236,6 +238,18 @@ public RuleSuppression(AttributeAst attrAst, int start, int end)
                     }
                 }
 
+                if (!String.IsNullOrWhiteSpace(Error))
+                {
+                    // May be cases where the rulename is null because we didn't look at the rulename after
+                    // we found out there is an error
+                    RuleName = String.Empty;
+                }
+                else if (String.IsNullOrWhiteSpace(RuleName))
+                {
+                    RuleName = String.Empty;
+                    Error = Strings.NullRuleNameError;
+                }
+                
                 // Must have scope and target together
                 if (String.IsNullOrWhiteSpace(Scope) && !String.IsNullOrWhiteSpace(Target))
                 {
@@ -329,7 +343,7 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at
                 }
                 else
                 {
-                    // this may add rule suppression that contains erro but we will check for this in the engine to throw out error
+                    // this may add rule suppression that contains error but we will check for this in the engine to throw out error
                     result.Add(ruleSupp);
                 }
             }

Engine/Helper.cs

@@ -743,6 +743,20 @@ public List<DiagnosticRecord> SuppressRule(string ruleName, Dictionary<string, L
 
             while (recordIndex < diagnostics.Count)
             {
+                if (!String.IsNullOrWhiteSpace(ruleSuppression.Error))
+                {
+                    ruleSuppressionIndex += 1;
+
+                    if (ruleSuppressionIndex == ruleSuppressions.Count)
+                    {
+                        break;
+                    }
+
+                    ruleSuppression = ruleSuppressions[ruleSuppressionIndex];
+
+                    continue;
+                }
+
                 // the record precedes the rule suppression so don't apply the suppression
                 if (record.Extent.StartOffset < ruleSuppression.StartOffset)
                 {

Engine/Strings.Designer.cs

@@ -183,4 +183,7 @@
   <data name="WrongScopeArgumentSuppressionAttributeError" xml:space="preserve">
     <value>Scope can only be either function or class.</value>
   </data>
+  <data name="NullRuleNameError" xml:space="preserve">
+    <value>RuleName must not be null.</value>
+  </data>
 </root>