Merge pull request #102 from PowerShell/revert-101-revert-100-BugFixes

Revert "Revert "Only Trigger PSProvideVerboseMessage in Advanced Scri…

Author: yutingc

Rules/ProvideVerboseMessage.cs

@@ -12,10 +12,12 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Management.Automation.Language;
 using Microsoft.Windows.Powershell.ScriptAnalyzer.Generic;
 using System.ComponentModel.Composition;
 using System.Globalization;
+using System.Management.Automation;
 
 namespace Microsoft.Windows.Powershell.ScriptAnalyzer.BuiltinRules
 {
@@ -33,11 +35,11 @@ public class ProvideVerboseMessage : SkipNamedBlock, IScriptRule
         public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
         {
             if (ast == null) throw new ArgumentNullException(Strings.NullAstErrorMessage);
-            
+
             ClearList();
             this.AddNames(new List<string>() { "Configuration", "Workflow" });
             DiagnosticRecords.Clear();
-            
+
             this.fileName = fileName;
             //We only check that advanced functions should have Write-Verbose
             ast.Visit(this);
@@ -57,6 +59,17 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
                 return AstVisitAction.SkipChildren;
             }
 
+            //Write-Verbose is not required for non-advanced functions
+            if (funcAst.Body != null && funcAst.Body.ParamBlock != null
+           && funcAst.Body.ParamBlock.Attributes != null &&
+           funcAst.Body.ParamBlock.Parameters != null)
+            {
+                if (!funcAst.Body.ParamBlock.Attributes.Any(attr => attr.TypeName.GetReflectionType() == typeof(CmdletBindingAttribute)))
+                {
+                    return AstVisitAction.Continue;
+                }
+            }
+
             var commandAsts = funcAst.Body.FindAll(testAst => testAst is CommandAst, false);
             bool hasVerbose = false;