Merge branch 'NewRule' into BugFixes

Author: yutingc

Rules/Strings.Designer.cs

@@ -658,10 +658,10 @@
     <value>Use ShouldProcess For State Changing Functions</value>
   </data>
   <data name="UseShouldProcessForStateChangingFunctionsDescrption" xml:space="preserve">
-    <value>Functions that have verbs like New, Start, Stop, Set, Reset that change systme state should support 'ShouldProcess'</value>
+    <value>Functions that have verbs like New, Start, Stop, Set, Reset that change system state should support 'ShouldProcess'.</value>
   </data>
   <data name="UseShouldProcessForStateChangingFunctionsError" xml:space="preserve">
-    <value>Function ’{0}’ has verb that could change system state. Therefore, the function has to support 'ShouldProcess'</value>
+    <value>Function ’{0}’ has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.</value>
   </data>
   <data name="UseShouldProcessForStateChangingFunctionsName" xml:space="preserve">
     <value>UseShouldProcessForStateChangingFunctions</value>

Rules/Strings.resx

@@ -1,4 +1,16 @@
-using System;
+//
+// Copyright (c) Microsoft Corporation.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+//
+
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Management.Automation;
@@ -32,12 +44,12 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 string funcName = funcDefAst.Name;
                 bool hasShouldProcessAttribute = false;
 
-                if (funcName.IndexOf("Get", StringComparison.OrdinalIgnoreCase) >= 0 ||
-                    funcName.IndexOf("Stop", StringComparison.OrdinalIgnoreCase) >= 0 ||
-                    funcName.IndexOf("New", StringComparison.OrdinalIgnoreCase) >= 0 ||
-                    funcName.IndexOf("Set", StringComparison.OrdinalIgnoreCase) >= 0 ||
-                    funcName.IndexOf("Update", StringComparison.OrdinalIgnoreCase) >= 0 ||
-                    funcName.IndexOf("Reset", StringComparison.OrdinalIgnoreCase) >= 0)
+                if (funcName.StartsWith("Get-", StringComparison.OrdinalIgnoreCase) ||
+                    funcName.StartsWith("Stop-", StringComparison.OrdinalIgnoreCase)||
+                    funcName.StartsWith("New-", StringComparison.OrdinalIgnoreCase) ||
+                    funcName.StartsWith("Set-", StringComparison.OrdinalIgnoreCase) ||
+                    funcName.StartsWith("Update-", StringComparison.OrdinalIgnoreCase) ||
+                    funcName.StartsWith("Reset-", StringComparison.OrdinalIgnoreCase))
                 {
                     IEnumerable<Ast> attributeAsts = funcDefAst.FindAll(testAst => testAst is NamedAttributeArgumentAst, true);
                     if (funcDefAst.Body != null && funcDefAst.Body.ParamBlock != null
@@ -51,9 +63,13 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
 
                         foreach (NamedAttributeArgumentAst attributeAst in attributeAsts)
                         {
-                            if (attributeAst.ArgumentName.Equals(supportsShouldProcess, StringComparison.OrdinalIgnoreCase) && attributeAst.Argument.Extent.Text.Equals(trueString, StringComparison.OrdinalIgnoreCase))
+                            if (attributeAst.ArgumentName.Equals(supportsShouldProcess, StringComparison.OrdinalIgnoreCase))
                             {
-                                hasShouldProcessAttribute = true;
+                                if((attributeAst.Argument.Extent.Text.Equals(trueString, StringComparison.OrdinalIgnoreCase)) && !attributeAst.ExpressionOmitted || 
+                                    attributeAst.ExpressionOmitted)
+                                {
+                                    hasShouldProcessAttribute = true;
+                                }
                             }
                         }