Throw error if target cannot be found for rulesuppression

Quoc Truong · Quoc Truong · commit d6d35b6227c1 · 2015-04-20T10:25:50.000-07:00
diff --git a/Engine/Generic/RuleSuppression.cs b/Engine/Generic/RuleSuppression.cs
@@ -334,6 +334,14 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at
 
                     if (targetAsts != null)
                     {
+                        if (targetAsts.Count() == 0)
+                        {
+                            ruleSupp.Error = String.Format(CultureInfo.CurrentCulture, Strings.RuleSuppressionErrorFormat, ruleSupp.StartOffset,
+                                System.IO.Path.GetFileName(scopeAst.Extent.File), String.Format(Strings.TargetCannotBeFoundError, ruleSupp.Target, ruleSupp.Scope));
+                            result.Add(ruleSupp);
+                            continue;
+                        }
+
                         foreach (Ast targetAst in targetAsts)
                         {
                             result.Add(new RuleSuppression(ruleSupp.RuleName, ruleSupp.RuleSuppressionID, targetAst.Extent.StartOffset, targetAst.Extent.EndOffset));
diff --git a/Engine/Strings.Designer.cs b/Engine/Strings.Designer.cs
diff --git a/Engine/Strings.resx b/Engine/Strings.resx
@@ -186,4 +186,7 @@
   <data name="NullRuleNameError" xml:space="preserve">
     <value>RuleName must not be null.</value>
   </data>
+  <data name="TargetCannotBeFoundError" xml:space="preserve">
+    <value>Cannot find any Targets {0} that match the Scope {1} to apply the SuppressMessageAttribute.</value>
+  </data>
 </root>

Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,14 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at`
`334`	`334`
`335`	`335`	`if (targetAsts != null)`
`336`	`336`	`{`
	`337`	`+ if (targetAsts.Count() == 0)`
	`338`	`+ {`
	`339`	`+ ruleSupp.Error = String.Format(CultureInfo.CurrentCulture, Strings.RuleSuppressionErrorFormat, ruleSupp.StartOffset,`
	`340`	`+ System.IO.Path.GetFileName(scopeAst.Extent.File), String.Format(Strings.TargetCannotBeFoundError, ruleSupp.Target, ruleSupp.Scope));`
	`341`	`+ result.Add(ruleSupp);`
	`342`	`+ continue;`
	`343`	`+ }`
	`344`	`+`
`337`	`345`	`foreach (Ast targetAst in targetAsts)`
`338`	`346`	`{`
`339`	`347`	`result.Add(new RuleSuppression(ruleSupp.RuleName, ruleSupp.RuleSuppressionID, targetAst.Extent.StartOffset, targetAst.Extent.EndOffset));`