Skip to content

Conversation

@AakashKumarNain
Copy link

Description

If the end user has weave installed in their environment, then the rollouts are traced with weave. If weave is not installed, then the old logging works as it is without breaking anything. Why weave for rollouts?

  1. Easier to visualize and go through the traces (see the first and the second images below)
  2. You can compare rollouts (check the third image below)

Though weave can trace an insane amount of information, here most of the things are turned off to focus just on rollouts tracing. The user always has an option to set the required env variables in case they want to trace everything

weave_1 weave_2 weave_3

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2025

CLA assistant check
All committers have signed the CLA.

@Sohailm25
Copy link

this is nice

added my own pr for abstracting some of the tracking, the deeper tracking with weave is clean #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants