Skip to content

Deepen Frost and Blake coverage (#219)#220

Merged
Pro777 merged 1 commit intomainfrom
Pro777/219-frost-blake
Apr 8, 2026
Merged

Deepen Frost and Blake coverage (#219)#220
Pro777 merged 1 commit intomainfrom
Pro777/219-frost-blake

Conversation

@Pro777
Copy link
Copy Markdown
Owner

@Pro777 Pro777 commented Apr 8, 2026

Summary

  • add Robert Frost as a new author with five poems from the public-domain collection New Hampshire
  • deepen William Blake with three more canonical poems and refresh Infant Joy metadata from the same Gutenberg source
  • add repeatable ingest support for Frost and extend the existing Blake Romantic ingest

Verification

  • cd site && npm run build

Closes #219

Summary by CodeRabbit

Release Notes

  • New Features
    • Added 5 Robert Frost poems: "Dust of Snow," "Fire and Ice," "Nothing Gold Can Stay," "Stopping by Woods on a Snowy Evening," and "The Need of Being Versed in Country Things"
    • Added 3 William Blake poems: "The Clod and the Pebble," "The Garden of Love," and "The Schoolboy"
    • Added biographical information for Robert Frost
    • Updated metadata for William Blake's "Infant Joy"

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bd75fc45-2773-4de4-8d25-c11c3d3d02e9

📥 Commits

Reviewing files that changed from the base of the PR and between 2aef1bf and 7e38d1f.

📒 Files selected for processing (20)
  • meta/robert-frost/dust-of-snow.yml
  • meta/robert-frost/fire-and-ice.yml
  • meta/robert-frost/nothing-gold-can-stay.yml
  • meta/robert-frost/stopping-by-woods-on-a-snowy-evening.yml
  • meta/robert-frost/the-need-of-being-versed-in-country-things.yml
  • meta/william-blake/infant-joy.yml
  • meta/william-blake/the-clod-and-the-pebble.yml
  • meta/william-blake/the-garden-of-love.yml
  • meta/william-blake/the-schoolboy.yml
  • poems/robert-frost/dust-of-snow.txt
  • poems/robert-frost/fire-and-ice.txt
  • poems/robert-frost/nothing-gold-can-stay.txt
  • poems/robert-frost/stopping-by-woods-on-a-snowy-evening.txt
  • poems/robert-frost/the-need-of-being-versed-in-country-things.txt
  • poems/william-blake/the-clod-and-the-pebble.txt
  • poems/william-blake/the-garden-of-love.txt
  • poems/william-blake/the-schoolboy.txt
  • scripts/ingest-gutenberg-frost-depth.mjs
  • scripts/ingest-gutenberg-romantic-depth.mjs
  • site/src/lib/authors.ts

📝 Walkthrough

Walkthrough

This PR adds five Robert Frost poems and four additional William Blake poems to the repository, including their metadata files and plain-text content. Two new ingestion scripts automate extracting poems from Project Gutenberg sources and generating corresponding metadata. Robert Frost is registered as a new author in the site configuration.

Changes

Cohort / File(s) Summary
Robert Frost metadata
meta/robert-frost/dust-of-snow.yml, meta/robert-frost/fire-and-ice.yml, meta/robert-frost/nothing-gold-can-stay.yml, meta/robert-frost/stopping-by-woods-on-a-snowy-evening.yml, meta/robert-frost/the-need-of-being-versed-in-country-things.yml
Five new metadata files defining Robert Frost poems with consistent structure: identifiers, author attribution, century, text path references, source URLs (Project Gutenberg eBook #58611), and public domain rationale.
Robert Frost poem texts
poems/robert-frost/*
Five new plain-text poem files containing the complete verse for Dust of Snow, Fire and Ice, Nothing Gold Can Stay, Stopping by Woods on a Snowy Evening, and The Need of Being Versed in Country Things.
William Blake metadata
meta/william-blake/the-clod-and-the-pebble.yml, meta/william-blake/the-garden-of-love.yml, meta/william-blake/the-schoolboy.yml; meta/william-blake/infant-joy.yml
Three new poem metadata files with standard structure (identifiers, author, century, text paths, source URLs, public domain rationale). One existing file (infant-joy.yml) updated: source_url changed to cached plain-text URL and public_domain_rationale revised to publication-date-based statement.
William Blake poem texts
poems/william-blake/the-clod-and-the-pebble.txt, poems/william-blake/the-garden-of-love.txt, poems/william-blake/the-schoolboy.txt
Three new plain-text poem files.
Ingestion scripts
scripts/ingest-gutenberg-frost-depth.mjs, scripts/ingest-gutenberg-romantic-depth.mjs
New script downloads Project Gutenberg plaintext eBook, strips boilerplate, and extracts Robert Frost poems using start/end text markers; writes poem texts and YAML metadata. Existing romantic script extended with five new William Blake poem definitions (slug, title, line boundaries).
Author registry
site/src/lib/authors.ts
Added Robert Frost entry to AUTHOR_INFO exported map with birth/death years, biography, and Wikipedia source attribution.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

ready-for-review

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Pro777/219-frost-blake

Comment @coderabbitai help to get the list of available commands and usage tips.

@Pro777 Pro777 force-pushed the Pro777/219-frost-blake branch from 100fb4f to 7e38d1f Compare April 8, 2026 23:15
@Pro777 Pro777 merged commit f29bd09 into main Apr 8, 2026
1 check passed
@Pro777 Pro777 deleted the Pro777/219-frost-blake branch April 8, 2026 23:15
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2aef1bf) to head (7e38d1f).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           51        51           
  Branches        12        12           
=========================================
  Hits            51        51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Romantic and early-modern American poet coverage wave III

2 participants