From 12b08f450a577a2094a6f87a27c59df3f3c0fe52 Mon Sep 17 00:00:00 2001 From: Teisha McRae Date: Wed, 12 Oct 2022 16:09:38 -0400 Subject: [PATCH 1/3] Update composer.json, add tests --- composer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 52d3ecd..565ae4b 100644 --- a/composer.json +++ b/composer.json @@ -15,7 +15,8 @@ }, "autoload": { "psr-4": { - "ProcessMaker\\Package\\PackageSkeleton\\": "src" + "ProcessMaker\\Package\\PackageSkeleton\\": "src", + "Tests\\": "tests/" } }, "extra": { From ff6a4f40c3115144e83e97082eb8201d072341d0 Mon Sep 17 00:00:00 2001 From: Teisha McRae Date: Wed, 12 Oct 2022 16:11:05 -0400 Subject: [PATCH 2/3] Use class-based routes --- routes/api.php | 7 ++++--- routes/web.php | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/routes/api.php b/routes/api.php index 7a08b7d..335e22e 100644 --- a/routes/api.php +++ b/routes/api.php @@ -1,5 +1,6 @@ ['auth:api', 'bindings']], function() { - Route::get('admin/package-skeleton/fetch', 'PackageSkeletonController@fetch')->name('package.skeleton.fetch'); - Route::apiResource('admin/package-skeleton', 'PackageSkeletonController'); + +Route::group(['middleware' => ['auth:api', 'bindings']], function () { + Route::get('admin/package-skeleton/fetch', [PackageSkeletonController::class, 'fetch'])->name('package.skeleton.fetch'); + Route::apiResource('admin/package-skeleton', PackageSkeletonController::class); }); diff --git a/routes/web.php b/routes/web.php index fc4ea15..cd0cb96 100644 --- a/routes/web.php +++ b/routes/web.php @@ -1,6 +1,6 @@ ['auth']], function () { - Route::get('admin/package-skeleton', 'PackageSkeletonController@index')->name('package.skeleton.index'); - Route::get('package-skeleton', 'PackageSkeletonController@index')->name('package.skeleton.tab.index'); + Route::get('admin/package-skeleton', [PackageSkeletonController::class, 'index'])->name('package.skeleton.index'); + Route::get('package-skeleton', [PackageSkeletonController::class, 'index'])->name('package.skeleton.tab.index'); }); From 95dbd22a073ae447be69f83dcf9654ad5d1f00cb Mon Sep 17 00:00:00 2001 From: Teisha McRae Date: Wed, 12 Oct 2022 16:11:35 -0400 Subject: [PATCH 3/3] Use base model --- src/Models/Sample.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Models/Sample.php b/src/Models/Sample.php index 198e80a..0639f58 100644 --- a/src/Models/Sample.php +++ b/src/Models/Sample.php @@ -2,13 +2,13 @@ namespace ProcessMaker\Package\PackageSkeleton\Models; -use Illuminate\Database\Eloquent\Model; +use ProcessMaker\Models\ProcessMakerModel; -class Sample extends Model +class Sample extends ProcessMakerModel { protected $table = 'sample_skeleton'; protected $fillable = [ - 'id', 'name', 'status' + 'id', 'name', 'status', ]; -} \ No newline at end of file +}