Skip to content

Tasks with status Self service do not reach Processes I manage #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolanpro merged 1 commit into from
Nov 17, 2025
Merged

Tasks with status Self service do not reach Processes I manage #8590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ProcessMaker/Http/Controllers/Api/TaskController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,17 @@ public function index(Request $request, $getTotal = false, User $user = null)

$this->applyStatusFilter($query, $request);

$this->applyPmql($query, $request, $user);

$this->applyAdvancedFilter($query, $request);

// Apply process manager filter BEFORE PMQL to avoid conflicts with is_self_service filtering
if ($request->input('processesIManage') === 'true') {
$this->applyProcessManager($query, $user);
} else {
$this->applyForCurrentUser($query, $user);
}

$this->applyPmql($query, $request, $user);

$this->applyAdvancedFilter($query, $request);

// Apply filter overdue
$query->overdue($request->input('overdue'));

Expand Down
33 changes: 31 additions & 2 deletions ProcessMaker/Traits/TaskControllerIndexMethods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,20 @@ private function applyPmql($query, $request, $user)
} catch (SyntaxError $e) {
abort('Your PMQL contains invalid syntax.', 400);
}

// After PMQL is applied, if processesIManage is active, add self-service tasks
// This is done after PMQL to avoid the is_self_service = 0 filter that PMQL might add
if ($request->input('processesIManage') === 'true' && isset($query->getQuery()->processManagerIds)) {
$ids = $query->getQuery()->processManagerIds;
$selfServiceTaskIds = ProcessRequestToken::select(['id'])
->whereIn('process_id', $ids)
->where('is_self_service', 1)
->whereNull('user_id')
->where('status', 'ACTIVE');

// Add self-service tasks using orWhereIn to override PMQL's is_self_service = 0 filter
$query->orWhereIn('process_request_tokens.id', $selfServiceTaskIds);
}
}
}

Expand Down Expand Up @@ -340,11 +354,26 @@ public function applyProcessManager($query, $user)
->orWhereRaw("JSON_CONTAINS(JSON_EXTRACT(properties, '$.manager_id'), CAST(? AS JSON))", [$user->id]);
})
->where('status', 'ACTIVE')
->get()
->pluck('id')
->toArray();

if (empty($ids)) {
// If user is not a manager of any process, return no results
$query->whereRaw('1 = 0');

return;
}

// Show tasks from processes the user manages that are ACTIVE
// OR show self-service tasks from those processes
// Store the process IDs in the query so we can use them later to add self-service tasks
// We'll add self-service tasks after PMQL is applied to avoid the is_self_service = 0 filter
$query->getQuery()->processManagerIds = $ids;

// Apply condition for regular tasks from managed processes
// Self-service tasks will be added after PMQL to avoid conflicts
$query->where(function ($query) use ($ids) {
$query->whereIn('process_request_tokens.process_id', array_column($ids, 'id'))
$query->whereIn('process_request_tokens.process_id', $ids)
->where('process_request_tokens.status', 'ACTIVE');
});
}
Expand Down
Loading