user link creation tests

Author: marter11

src/api/controllers/projectController.py

@@ -69,6 +69,7 @@ def create_link(self, project_id, **kwargs):
 
             return link
         except:
+            self.session.rollback()
             return None
 
     def update_link(self, project_id, link_id, **kwargs):
@@ -113,6 +114,7 @@ def create_feedback(self, project_id, **kwargs):
 
             return feedback
         except:
+            self.session.rollback()
             return None
 
     def get_all_feedbacks(self, project_id):

tests/api/__init__.py

@@ -17,7 +17,13 @@ def create_project_for_test_cases(data):
     new_project = Project(**data)
     db.session.add(new_project)
     db.session.commit()
-    return new_project.id
+    return new_project.as_dict()
+
+def create_project_link_for_test_cases(data):
+    new_project_link = ProjectLink(**data)
+    db.session.add(new_project_link)
+    db.session.commit()
+    return new_project_link.as_dict()
 
 def create_user_for_test_cases(data):
     new_user = User(**data)
@@ -27,12 +33,6 @@ def create_user_for_test_cases(data):
 
 def create_user_link_for_test_cases(data):
     new_user_link = UserLink(**data)
-    db.session.add(new_user)
+    db.session.add(new_user_link)
     db.session.commit()
     return new_user_link.as_dict()
-
-def create_project_for_test_cases(data):
-    new_project_link = ProjectLink(**data)
-    db.session.add(new_project_link)
-    db.session.commit()
-    return new_project_link.as_dict()

tests/api/views/test_projectView.py

@@ -1,7 +1,7 @@
 from tests.conftest import client
 from tests import db, Project
-from tests.api import create_project_for_test_cases
 
+from tests.api import create_project_for_test_cases
 class TestProjectView(object):
 
     valid_data = {
@@ -41,3 +41,13 @@ def test_delete_project(self, client):
         # project_id = self.create_project_for_test_cases()
         # response = client.delete('/project/{}'.format(project_id))
         # assert response.status_code == 202
+
+    def test_create_porject_link(self, client):
+        project = create_project_for_test_cases(self.valid_data)
+        url = '/projects/{}/links'.format(project["id"])
+
+        response = client.post(url, json={"user_id": 0})
+        assert response.status_code == 400
+
+        response = client.post(url, json={"name": "Main link", "url": "http://main.link"})
+        assert response.status_code == 201

tests/api/views/test_userView.py

@@ -1,6 +1,6 @@
 from tests.conftest import client
-from tests import db, User
-from tests.api import create_user_for_test_cases
+from tests import db, User, UserLink
+from tests.api import create_user_for_test_cases, create_user_link_for_test_cases
 
 class TestUserView(object):
 
@@ -84,17 +84,77 @@ def test_get_all_users(self, client):
         assert response.status_code == 200
         assert response.get_json() == [users_dict[1]]
 
-    # notice: Why do we need name in UserLink?
-    # notice: Won't the API will provide the UserLink, then why the endpoint expects a UserLink specification?
     def test_create_user_link(self, client):
         user = create_user_for_test_cases(self.valid_data)
         url = '/users/{}/links'.format(user["id"])
 
         response = client.post(url, json={"user_id": user["id"]})
         assert response.status_code == 400
 
-        # response = client.post(url, )
-        # assert 1 == 1
+        response = client.post(url, json={"name": "Smedia", "url": "http://s.media"})
+        assert response.status_code == 201
+
+        response = client.post(url, json={"name": None, "url": "http://l.co"})
+        assert response.status_code == 400
+
+        response = client.post(url, json={"name": "WORK"})
+        assert response.status_code == 400
+
+    def test_update_user_link(self, client):
+        user = create_user_for_test_cases(self.valid_data)
+        link = create_user_link_for_test_cases({"name": "Discord", "url": "http://dc.com/my", "user_id": user["id"]})
+
+        url = "/users/{0}/links/{1}".format(0, link["id"])
+
+        response = client.post(url, json={"name": "Portfolio"})
+        assert response.status_code == 400
+
+        url = "/users/{0}/links/{1}".format(user["id"], link["id"])
+
+        response = client.post(url, json={"user_id": 0})
+        assert response.status_code == 400
+
+        response = client.post(url, json={"link_id": 1})
+        assert response.status_code == 400
+
+        # notice: Should we respond to update_user request without json data with status code 200?
+        # response = client.post(url, json={})
+        # assert response.status_code == 400
+
+        response = client.post(url, json={"name": "New Name"})
+        assert response.status_code == 200
+        assert response.get_json()["name"] == "New Name"
+
+    def test_get_all_user_links(self, client):
+        user = create_user_for_test_cases(self.valid_data)
+        link1 = create_user_link_for_test_cases({"name": "Discord", "url": "http://dc.com/my", "user_id": user["id"]})
+        link2 = create_user_link_for_test_cases({"name": "PB", "url": "http://pb.com/ur234", "user_id": user["id"]})
+
+        response = client.get("/users/{}/links".format(user["id"]))
+        assert response.status_code == 200
+        assert response.get_json() == [link1, link2]
+
+    def test_delete_user_link(self, client):
+        user = create_user_for_test_cases(self.valid_data)
+        link1 = UserLink(**{"name": "Discord", "url": "http://dc.com/my", "user_id": user["id"]})
+        link2 = UserLink(**{"name": "PB", "url": "http://pb.com/ur234", "user_id": user["id"]})
+
+        db.session.add(link1)
+        db.session.add(link2)
+        db.session.commit()
+
+        response = client.delete("/users/{0}/links/{1}".format(0, link1.id))
+        assert response.status_code == 404
+
+        response = client.delete("/users/{0}/links/{1}".format(user["id"], 0))
+        assert response.status_code == 404
+
+        response = client.delete("/users/{0}/links/{1}".format(user["id"], link1.id))
+        assert response.status_code == 200
+
+        recorded_links = UserLink.query.all()
+        assert len(recorded_links) == 1
+        assert link1 not in recorded_links
 
     def test_create_user_feedback(self, client):
         user1 = create_user_for_test_cases(self.valid_data)