shared functions

Author: marter11

tests/__init__.py

@@ -6,6 +6,6 @@
 
 from api import app
 from api.models import db
-from api.models import User, Project
+from api.models import User, Project, UserFeedback, ProjectFeedback, UserLink, ProjectLink
 
 sys.path.insert(0, os.getcwd()+'/tests')

tests/api/__init__.py

@@ -0,0 +1,38 @@
+
+"""
+
+  Creates valid model objects for testing purposes:
+
+    - insert data to the database which could be used for testing
+
+    - these functions will give back the created objects in dict format which is hardcoded at every model's as_dict instance method
+
+    - call these functions form any test case.
+
+"""
+
+from tests import db, Project, User, UserLink, ProjectLink
+
+def create_project_for_test_cases(data):
+    new_project = Project(**data)
+    db.session.add(new_project)
+    db.session.commit()
+    return new_project.id
+
+def create_user_for_test_cases(data):
+    new_user = User(**data)
+    db.session.add(new_user)
+    db.session.commit()
+    return new_user.as_dict()
+
+def create_user_link_for_test_cases(data):
+    new_user_link = UserLink(**data)
+    db.session.add(new_user)
+    db.session.commit()
+    return new_user_link.as_dict()
+
+def create_project_for_test_cases(data):
+    new_project_link = ProjectLink(**data)
+    db.session.add(new_project_link)
+    db.session.commit()
+    return new_project_link.as_dict()

tests/api/views/test_projectView.py

@@ -1,21 +1,15 @@
 from tests.conftest import client
 from tests import db, Project
-from datetime import datetime
+from tests.api import create_project_for_test_cases
 
-class TestPorjectView(object):
+class TestProjectView(object):
 
     valid_data = {
         'name': 'PB api',
         'description': 'A cool project',
         'repository': 'http://github.xy.com'
     }
 
-    def create_project_for_test_cases(self):
-        new_project = Project(**self.valid_data)
-        db.session.add(new_project)
-        db.session.commit()
-        return new_project.id
-
     def test_create_project(self, client):
         response = client.post('/projects', json={"name": "Project"})
         assert response.status_code == 400
@@ -34,7 +28,7 @@ def test_update_project(self, client):
         # notice: should return 404 when doesen't exist insted of 400
         assert response.status_code == 404
 
-        project_id = self.create_project_for_test_cases()
+        project_id = create_project_for_test_cases(self.valid_data)
         response = client.post('/projects/{}'.format(project_id), json={'description': 'updated desc'})
         project = Project.query.filter_by(id=project_id).first()
         assert project.description == 'updated desc'

tests/api/views/test_userView.py

@@ -1,8 +1,10 @@
 from tests.conftest import client
 from tests import db, User
+from tests.api import create_user_for_test_cases
 
 class TestUserView(object):
 
+    # valid data for user creation
     valid_data = {
         'name': 'L Jone',
         'bio': 'coding...',
@@ -12,12 +14,6 @@ class TestUserView(object):
         'occupation': 'cashier'
     }
 
-    def create_user_for_test_cases(self):
-        new_user = User(**self.valid_data)
-        db.session.add(new_user)
-        db.session.commit()
-        return new_user.id
-
     def test_create_user(self, client):
         response = client.post('/users', json=self.valid_data)
         assert response.status_code == 201
@@ -26,7 +22,7 @@ def test_create_user(self, client):
         assert response.status_code == 400
 
     def test_update_user(self, client):
-        user_id = self.create_user_for_test_cases()
+        user_id = create_user_for_test_cases(self.valid_data)["id"]
 
         response = client.post('/users/1', json={})
         assert response.status_code == 400
@@ -38,15 +34,14 @@ def test_update_user(self, client):
         response = client.post('/users/{}'.format(user_id), json={"name": "Updated Name"})
         assert response.status_code == 200
 
-        # created_user = User.query.filter_by(id=user_id).first()
         assert response.get_json()['name'] == "Updated Name"
 
     def test_delete_user(self, client):
         user_id = None
         response = client.delete('/users/{}'.format(user_id))
         assert response.status_code == 404
 
-        user_id = self.create_user_for_test_cases()
+        user_id = create_user_for_test_cases(self.valid_data)["id"]
         response = client.delete('/users/{}'.format(user_id))
         assert response.status_code == 200
 
@@ -55,15 +50,14 @@ def test_get_user(self, client):
         response = client.get('/users/{}'.format(user_id))
         assert response.status_code == 404
 
-        user_id = self.create_user_for_test_cases()
+        user = create_user_for_test_cases(self.valid_data)
+        user_id = user["id"]
         response = client.get('/users/{}'.format(user_id))
         assert response.status_code == 200
-
-        created_user = User.query.filter_by(id=user_id).first()
-        assert response.get_json() == created_user.as_dict()
+        assert response.get_json() == user
 
     def test_get_all_users(self, client):
-        self.create_user_for_test_cases()
+        create_user_for_test_cases(self.valid_data)
 
         self.valid_data = {
             'name': 'Valid',
@@ -74,7 +68,7 @@ def test_get_all_users(self, client):
             'occupation': 'cashier2.1'
         }
 
-        self.create_user_for_test_cases()
+        create_user_for_test_cases(self.valid_data)
 
         response = client.get('/users')
         assert response.status_code == 200
@@ -89,3 +83,34 @@ def test_get_all_users(self, client):
         response = client.get('/users')
         assert response.status_code == 200
         assert response.get_json() == [users_dict[1]]
+
+    # notice: Why do we need name in UserLink?
+    # notice: Won't the API will provide the UserLink, then why the endpoint expects a UserLink specification?
+    def test_create_user_link(self, client):
+        user = create_user_for_test_cases(self.valid_data)
+        url = '/users/{}/links'.format(user["id"])
+
+        response = client.post(url, json={"user_id": user["id"]})
+        assert response.status_code == 400
+
+        # response = client.post(url, )
+        # assert 1 == 1
+
+    def test_create_user_feedback(self, client):
+        user1 = create_user_for_test_cases(self.valid_data)
+
+        self.valid_data["name"] = "Other name"
+        user2 = create_user_for_test_cases(self.valid_data)
+
+        url = '/users/{}/feedbacks'.format(user2["id"])
+        response = client.post(url, json={"user_id": user2["id"]})
+        assert response.status_code == 400
+
+        feedback = {
+            "author_id": int(user1["id"]),
+            "rating": 5,
+            "description": "Cool guy!",
+        }
+
+        response = client.post(url, json=feedback)
+        assert response.status_code == 201

tests/conftest.py

@@ -1,8 +1,18 @@
+
+"""
+
+When the testing process is starting this file will run at first.
+
+This should contain all the neccessary functions for the test flow or at least should be imported here.
+
+"""
+
 import pytest
 from sqlalchemy_utils import database_exists, create_database
 from os import environ
 from tests import app, db
 
+# Provide default test client for testing endpoints
 @pytest.fixture
 def client():