adding default podPriorityClassName

Signed-off-by: Neil South <neil.south@answerdigital.com>

Author: neildsouth

src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs

@@ -434,7 +434,7 @@ private void ProcessTaskPluginArguments(Workflow workflow)
             Guard.Against.Null(workflow);
 
             var resources = Event.GetTaskPluginArgumentsParameter<Dictionary<string, string>>(Keys.ArgoResource);
-            var priorityClassName = Event.GetTaskPluginArgumentsParameter(Keys.TaskPriorityClassName);
+            var priorityClassName = Event.GetTaskPluginArgumentsParameter(Keys.TaskPriorityClassName) ?? "standard";
             var argoParameters = Event.GetTaskPluginArgumentsParameter<Dictionary<string, string>>(Keys.ArgoParameters);
 
             if (argoParameters is not null)
@@ -462,16 +462,9 @@ private void ProcessTaskPluginArguments(Workflow workflow)
                 AddRequest(resources, template, ResourcesKeys.CpuReservation);
                 AddRequest(resources, template, ResourcesKeys.MemoryReservation);
                 AddRequest(resources, template, ResourcesKeys.GpuLimit);
-
-                if (priorityClassName is not null)
-                {
-                    template.PriorityClassName = priorityClassName;
-                }
-            }
-            if (priorityClassName is not null)
-            {
-                workflow.Spec.PodPriorityClassName = priorityClassName;
+                template.PriorityClassName = priorityClassName;
             }
+            workflow.Spec.PodPriorityClassName = priorityClassName;
         }
 
         private static void AddLimit(Dictionary<string, string>? resources, Template2 template, ResourcesKey key)

tests/UnitTests/TaskManager.Argo.Tests/ArgoPluginTest.cs

@@ -806,6 +806,68 @@ public async Task ArgoPlugin_CreateArgoTemplate_Valid_json_Calls_Client()
             Times.Once);
     }
 
+    [Fact(DisplayName = "podPriorityClassName gets set if not given in workflow")]
+    public async Task ArgoPlugin_Ensures_podPriorityClassName_is_set()
+    {
+        var argoTemplate = LoadArgoTemplate("SimpleTemplate.yml");
+        Assert.NotNull(argoTemplate);
+
+        SetUpSimpleArgoWorkFlow(argoTemplate);
+
+        var message = GenerateTaskDispatchEventWithValidArguments();
+
+        WorkflowCreateRequest? requestMade = default;
+        ArgoClient.Setup(a => a.Argo_CreateWorkflowAsync(It.IsAny<string>(), It.IsAny<WorkflowCreateRequest>(), It.IsAny<CancellationToken>()))
+         .Callback<string, WorkflowCreateRequest, CancellationToken>((name, request, token) =>
+             {
+                 requestMade = request;
+             });
+
+        var defaultClassName = "standard";
+        var runner = new ArgoPlugin(ServiceScopeFactory.Object, _logger.Object, Options, message);
+        var result = await runner.ExecuteTask(CancellationToken.None).ConfigureAwait(false);
+
+        Assert.NotNull(requestMade);
+        Assert.Equal(defaultClassName, requestMade.Workflow.Spec.PodPriorityClassName);
+
+        foreach (var template in requestMade.Workflow.Spec.Templates)
+        {
+            Assert.Equal(defaultClassName, template.PriorityClassName);
+        }
+    }
+
+    [Fact(DisplayName = "podPriorityClassName gets set if given in workflow")]
+    public async Task ArgoPlugin_Ensures_podPriorityClassName_is_set_as_given()
+    {
+        var argoTemplate = LoadArgoTemplate("SimpleTemplate.yml");
+        Assert.NotNull(argoTemplate);
+
+        SetUpSimpleArgoWorkFlow(argoTemplate);
+
+        var message = GenerateTaskDispatchEventWithValidArguments();
+
+        var givenClassName = "fred";
+        message.TaskPluginArguments.Add("priority", givenClassName);
+
+        WorkflowCreateRequest? requestMade = default;
+        ArgoClient.Setup(a => a.Argo_CreateWorkflowAsync(It.IsAny<string>(), It.IsAny<WorkflowCreateRequest>(), It.IsAny<CancellationToken>()))
+         .Callback<string, WorkflowCreateRequest, CancellationToken>((name, request, token) =>
+         {
+             requestMade = request;
+         });
+
+        var runner = new ArgoPlugin(ServiceScopeFactory.Object, _logger.Object, Options, message);
+        var result = await runner.ExecuteTask(CancellationToken.None).ConfigureAwait(false);
+
+        Assert.NotNull(requestMade);
+        Assert.Equal(givenClassName, requestMade.Workflow.Spec.PodPriorityClassName);
+
+        foreach (var template in requestMade.Workflow.Spec.Templates)
+        {
+            Assert.Equal(givenClassName, template.PriorityClassName);
+        }
+    }
+
     private void SetUpSimpleArgoWorkFlow(WorkflowTemplate argoTemplate)
     {
         Assert.NotNull(argoTemplate);