Skip to content

Commit 27ef7ce

Browse files
committed
Revert "fix: test"
This reverts commit 002b1b9.
1 parent 002b1b9 commit 27ef7ce

File tree

3 files changed

+14
-23
lines changed

3 files changed

+14
-23
lines changed

ProjectVG.Tests/Application/Integration/CharacterServiceIntegrationTests.cs

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public async Task CreateDeleteAndTryRetrieveCharacterAsync_ShouldRemoveFromDatab
141141
existsBefore.Should().BeTrue();
142142

143143
// Act - Delete
144-
await _characterService.DeleteCharacterAsync(createdCharacter.Id, createCommand.UserId!.Value);
144+
await _characterService.DeleteCharacterAsync(createdCharacter.Id);
145145

146146
// Assert - Should not exist
147147
var existsAfter = await _characterService.CharacterExistsAsync(createdCharacter.Id);
@@ -160,26 +160,24 @@ public async Task DeleteNonExistentCharacter_ShouldThrowNotFoundException()
160160
var nonExistentId = Guid.NewGuid();
161161

162162
// Act & Assert
163-
var userId = Guid.NewGuid();
164163
await Assert.ThrowsAsync<NotFoundException>(
165-
() => _characterService.DeleteCharacterAsync(nonExistentId, userId));
164+
() => _characterService.DeleteCharacterAsync(nonExistentId));
166165
}
167166

168167
[Fact]
169168
public async Task DeleteCharacterFromMultipleCharacters_ShouldOnlyDeleteSpecificCharacter()
170169
{
171170
// Arrange
172171
await _fixture.ClearDatabaseAsync();
173-
var command1 = TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 1");
174-
var command2 = TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 2");
175-
var command3 = TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 3");
176-
177-
var character1 = await _characterService.CreateCharacterWithFieldsAsync(command1);
178-
var character2 = await _characterService.CreateCharacterWithFieldsAsync(command2);
179-
var character3 = await _characterService.CreateCharacterWithFieldsAsync(command3);
172+
var character1 = await _characterService.CreateCharacterWithFieldsAsync(
173+
TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 1"));
174+
var character2 = await _characterService.CreateCharacterWithFieldsAsync(
175+
TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 2"));
176+
var character3 = await _characterService.CreateCharacterWithFieldsAsync(
177+
TestDataBuilder.CreateCreateCharacterWithFieldsCommand("Character 3"));
180178

181179
// Act - Delete middle character
182-
await _characterService.DeleteCharacterAsync(character2.Id, command2.UserId!.Value);
180+
await _characterService.DeleteCharacterAsync(character2.Id);
183181

184182
// Assert
185183
var allCharacters = await _characterService.GetAllCharactersAsync();
@@ -257,7 +255,7 @@ public async Task CompleteCharacterLifecycle_ShouldWorkCorrectly()
257255
retrievedAfterUpdate.Name.Should().Be("Updated Lifecycle Character");
258256

259257
// Delete
260-
await _characterService.DeleteCharacterAsync(createdCharacter.Id, createCommand.UserId!.Value);
258+
await _characterService.DeleteCharacterAsync(createdCharacter.Id);
261259

262260
// Verify deletion
263261
var existsAfterDelete = await _characterService.CharacterExistsAsync(createdCharacter.Id);

ProjectVG.Tests/Application/Services/Character/CharacterServiceTests.cs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -489,17 +489,15 @@ public async Task DeleteCharacterAsync_WithValidId_ShouldDeleteCharacter()
489489
{
490490
// Arrange
491491
var characterId = Guid.NewGuid();
492-
var userId = Guid.NewGuid();
493492
var character = TestDataBuilder.CreateCharacterEntityWithIndividualConfig("TestCharacter", characterId);
494-
character.UserId = userId;
495493

496494
_mockCharacterRepository.Setup(x => x.GetByIdAsync(characterId))
497495
.ReturnsAsync(character);
498496
_mockCharacterRepository.Setup(x => x.DeleteAsync(characterId))
499497
.Returns(Task.CompletedTask);
500498

501499
// Act
502-
await _characterService.DeleteCharacterAsync(characterId, userId);
500+
await _characterService.DeleteCharacterAsync(characterId);
503501

504502
// Assert
505503
_mockCharacterRepository.Verify(x => x.GetByIdAsync(characterId), Times.Once);
@@ -511,14 +509,13 @@ public async Task DeleteCharacterAsync_WithNonExistentId_ShouldThrowNotFoundExce
511509
{
512510
// Arrange
513511
var characterId = Guid.NewGuid();
514-
var userId = Guid.NewGuid();
515512

516513
_mockCharacterRepository.Setup(x => x.GetByIdAsync(characterId))
517514
.ReturnsAsync((ProjectVG.Domain.Entities.Characters.Character?)null);
518515

519516
// Act & Assert
520517
var exception = await Assert.ThrowsAsync<NotFoundException>(
521-
() => _characterService.DeleteCharacterAsync(characterId, userId)
518+
() => _characterService.DeleteCharacterAsync(characterId)
522519
);
523520

524521
exception.ErrorCode.Should().Be(ErrorCode.CHARACTER_NOT_FOUND);
@@ -531,17 +528,15 @@ public async Task DeleteCharacterAsync_ShouldLogCharacterDeletion()
531528
{
532529
// Arrange
533530
var characterId = Guid.NewGuid();
534-
var userId = Guid.NewGuid();
535531
var character = TestDataBuilder.CreateCharacterEntityWithIndividualConfig("DeleteTestCharacter", characterId);
536-
character.UserId = userId;
537532

538533
_mockCharacterRepository.Setup(x => x.GetByIdAsync(characterId))
539534
.ReturnsAsync(character);
540535
_mockCharacterRepository.Setup(x => x.DeleteAsync(characterId))
541536
.Returns(Task.CompletedTask);
542537

543538
// Act
544-
await _characterService.DeleteCharacterAsync(characterId, userId);
539+
await _characterService.DeleteCharacterAsync(characterId);
545540

546541
// Assert
547542
_mockLogger.Verify(

ProjectVG.Tests/Application/TestUtilities/TestDataBuilder.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ public static CreateCharacterWithFieldsCommand CreateCreateCharacterWithFieldsCo
111111
string? speechStyle = "Casual",
112112
string? summary = "Test character summary",
113113
string? userAlias = "User",
114-
string? imageUrl = null,
115-
Guid? userId = null)
114+
string? imageUrl = null)
116115
{
117116
return new CreateCharacterWithFieldsCommand
118117
{
@@ -121,7 +120,6 @@ public static CreateCharacterWithFieldsCommand CreateCreateCharacterWithFieldsCo
121120
IsActive = isActive,
122121
VoiceId = voiceId,
123122
ImageUrl = imageUrl ?? string.Empty,
124-
UserId = userId ?? Guid.NewGuid(),
125123
IndividualConfig = new IndividualConfig
126124
{
127125
Role = role,

0 commit comments

Comments
 (0)