Psalm fixes.

Author: ProklUng

ControllersMiddleware/CsrfMiddleware.php

@@ -39,11 +39,11 @@ public function __construct(CsrfTokenManagerInterface $csrfTokenManager)
      */
     public function handle(Request $request): ?Response
     {
-        $typeRequest = $request->server->get('REQUEST_METHOD');
-        $token = $request->query->get('csrf_token');
+        $typeRequest = (string)$request->server->get('REQUEST_METHOD', '');
+        $token = (string)$request->query->get('csrf_token');
 
         if ($typeRequest !== 'GET') {
-            $token = $request->request->get('csrf_token');
+            $token = (string)$request->request->get('csrf_token');
         }
 
         $bValidToken = $this->csrfTokenManager->isTokenValid(

ControllersMiddleware/StaticFileMiddleware.php

@@ -102,7 +102,7 @@ private function getRequestTarget(Request $request) : string
 
         if ($request->getQueryString()) {
             $target = $request->getQueryString();
-            parse_str($target, $result);
+            parse_str((string)$target, $result);
             $target = (string)$result['file'];
         }
 

DependencyInjection/CompilerPass/ControllerMiddlewarePass.php

@@ -22,6 +22,9 @@ public function process(ContainerBuilder $container): void
     {
         $def = $container->getDefinition(MiddlewareServiceLocator::class);
 
+        /**
+         * @psalm-suppress MixedAssignment
+         */
         foreach ($container->findTaggedServiceIds(MiddlewareEnum::CONTROLLER_TAG) as $id => $attributes) {
             if (empty($attributes)) {
                 throw new \InvalidArgumentException('Provide at least "middleware" attribute');

DependencyInjection/CompilerPass/RouteMiddlewarePass.php

@@ -24,6 +24,9 @@ public function process(ContainerBuilder $container): void
 
         $def->addMethodCall('addRouteMiddlewares', [new Reference('router.default')]);
 
+        /**
+         * @var string $id
+         */
         foreach ($container->findTaggedServiceIds(MiddlewareEnum::ALIAS_SUFFIX) as $id => $arguments) {
             $container->setAlias($id . MiddlewareEnum::ALIAS_SUFFIX, $id)->setPublic(true);
         }

Middleware/MiddlewareFacade.php

@@ -76,7 +76,7 @@ public function getMiddlewaresToHandle(ControllerMetadata $controllerMetadata, R
             $controllerMetadata->getControllerFqcn()
         );
 
-        $routeMiddlewares = $this->middlewareServiceLocator->getRouteMiddlewares($request->get('_route', ''));
+        $routeMiddlewares = $this->middlewareServiceLocator->getRouteMiddlewares((string)$request->get('_route', ''));
 
         return $this->middlewareMerger->merge(
             $globalMiddlewares,

ServiceLocator/MiddlewareServiceLocator.php

@@ -143,7 +143,7 @@ public function addRouteMiddlewares($routeCollection): void
     /**
      * @param string $route_name
      *
-     * @return MiddlewareInterface[]
+     * @return array
      */
     public function getRouteMiddlewares(string $route_name): array
     {

composer.json

@@ -35,6 +35,8 @@
         "symfony/security-csrf": "^4.0 || ^5.0",
         "symfony/event-dispatcher": "^4.0 || ^5.0",
         "proklung/base-exception": "^1.0"
-
+    },
+    "require-dev": {
+        "proklung/phpunit-testing-tools": "^1.0"
     }
 }

psalm.xml

@@ -0,0 +1,38 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="1"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    allowStringToStandInForClass="true"
+    allowCoercionFromStringToClassConst="true"
+    findUnusedPsalmSuppress="true"
+    skipChecksOnUnresolvableIncludes="true"
+>
+    <plugins>
+        <pluginClass class="Psalm\SymfonyPsalmPlugin\Plugin"/>
+        <pluginClass class="Psalm\MockeryPlugin\Plugin"/>
+    </plugins>
+    <projectFiles>
+        <directory name="/"/>
+        <ignoreFiles>
+            <directory name="vendor"/>
+            <directory name="Examples"/>
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <MixedInferredReturnType>
+            <errorLevel type="suppress">
+                <file name="ServiceLocator/MiddlewareServiceLocator.php"/>
+            </errorLevel>
+        </MixedInferredReturnType>
+        <UnusedVariable>
+            <errorLevel type="suppress">
+                <directory name="DependencyInjection"/>
+            </errorLevel>
+        </UnusedVariable>
+    </issueHandlers>
+
+</psalm>