environment.py lazy_import() Seems to be Unused

[Kinvert]

PufferLib/pufferlib/ocean/environment.py

Line 4 in 6b2cbb9

def lazy_import(module_path, attr):

https://github.com/search?q=repo%3APufferAI%2FPufferLib%20lazy_import&type=code

[nadzhou]

There must be a reason why this was there.

[Kinvert]

Yeah but the question is if it's a reason that still exists.

[nadzhou]

Seems like it is needed as you can see here in this commit message:

removed stupid warning by only importing the necessary ocean env

4bcb316

Is there any reason you think it should be unused when there's an explicit commit to make the import load lazily?

[jacobarrio]

Checked out commit 4bcb316 and lazy_import() is actually being used.
It gets hit 15+ times inside the MAKE_FNS dict through those lambda wrappers, like:

'breakout': lambda: lazy_import('pufferlib.ocean.breakout.breakout', 'Breakout'),
'pong': lambda: lazy_import('pufferlib.ocean.pong.pong', 'Pong'),

etc.

My grep missed it because the calls are tucked inside the lambdas. So it’s not dead code it’s there on purpose for lazy loading and to avoid import warnings.