copilot review

Author: Jammy2211

autoarray/dataset/interferometer/dataset.py

@@ -193,7 +193,7 @@ def apply_w_tilde(
 
         if curvature_preload is None:
 
-            logger.info("INTERFEROMETER – Computing W-Tilde; runtime scales with visibility count and mask resolution, extreme inputs may exceed hours.")
+            logger.info("INTERFEROMETER - Computing W-Tilde; runtime scales with visibility count and mask resolution, extreme inputs may exceed hours.")
 
             curvature_preload = inversion_interferometer_util.w_tilde_curvature_preload_interferometer_from(
                 noise_map_real=self.noise_map.array.real,

autoarray/dataset/interferometer/w_tilde.py

@@ -1,6 +1,5 @@
 import json
 import hashlib
-from dataclasses import dataclass
 import numpy as np
 from pathlib import Path
 from typing import Any, Dict, Optional, Tuple, Union
@@ -98,7 +97,7 @@ def is_preload_metadata_compatible(
     require_mask_hash
         If True, require the full mask sha256 to match (safest).
         If False, only check bbox + shape + pixel scales.
-    rtol, atol
+    atol
         Tolerances for pixel scale comparisons (normally exact is fine
         because these are configuration constants, but tolerances allow
         for tiny float repr differences).
@@ -172,8 +171,8 @@ def load_curvature_preload_if_compatible(
 
     Returns
     -------
-    np.ndarray or None
-        The loaded curvature_preload if compatible, otherwise None (unless raise_on_mismatch=True).
+    np.ndarray
+        The loaded curvature_preload if compatible, otherwise raises ValueError.
     """
     file = Path(file)
     if file.suffix.lower() != ".npz":

autoarray/inversion/inversion/interferometer/inversion_interferometer_util.py

@@ -293,23 +293,21 @@ def w_tilde_curvature_preload_interferometer_via_np_from(
     # -------------------------------------------------
     pbar = None
     if show_progress:
-        try:
-            from tqdm import tqdm  # type: ignore
-
-            n_quadrants = 1
-            if x_shape > 1:
-                n_quadrants += 1
-            if y_shape > 1:
-                n_quadrants += 1
-            if (y_shape > 1) and (x_shape > 1):
-                n_quadrants += 1
-
-            pbar = tqdm(
-                total=n_chunks * n_quadrants,
-                desc="Accumulating visibilities (W-tilde preload)",
-            )
-        except Exception:
-            pbar = None
+
+        from tqdm import tqdm  # type: ignore
+
+        n_quadrants = 1
+        if x_shape > 1:
+            n_quadrants += 1
+        if y_shape > 1:
+            n_quadrants += 1
+        if (y_shape > 1) and (x_shape > 1):
+            n_quadrants += 1
+
+        pbar = tqdm(
+            total=n_chunks * n_quadrants,
+            desc="Accumulating visibilities (W-tilde preload)",
+        )
 
     def accum_from_corner_np(y_ref, x_ref, gy_block, gx_block):
         dy = y_ref - gy_block
@@ -327,10 +325,7 @@ def accum_from_corner_np(y_ref, x_ref, gy_block, gx_block):
                 pbar.update(1)
 
             if show_memory and show_progress and "_report_memory" in globals():
-                try:
-                    globals()["_report_memory"](acc)
-                except Exception:
-                    pass
+                globals()["_report_memory"](acc)
 
         return acc
 

test_autoarray/dataset/interferometer/test_dataset.py

@@ -178,6 +178,8 @@ def test__curvature_preload_metadata_from(
         file=file, real_space_mask=dataset.real_space_mask
     )
 
+    assert curvature_preload[0,0] == pytest.approx(1.75, 1.0e-4)
+
     real_space_mask_changed = np.array(
         [
             [True, True, True, True, True, True, True],