ICON2D name() overriding GEOM &name()

[pKrime]

Hi and thanks for this fork! I managed to build jot-lib on ubuntu 12.04, but I had to deal with an overriding error I had when compiling:

in file src/geom/icon2d.H at line 56

Cstr_ptr name() const {return _name; }

seems to conflict with src/geom/geom.H at line

Cstr_ptr &name() const { return _name; }

It makes sense to me, so I just put an ampersand in icon2d.H and compiled happily, but my C++ skills are very limited so I've no idea if I did it right. Maybe it's just versions or something.

Thanks

[tombsar]

I also ran into this problem, and made the same change as you to get the code to compile.

I am pretty sure it is a mistake in the original code (https://code.google.com/p/jot-lib/), as the two lines are clearly contradictory.

QuLogic has fixed this problem in the (as yet unmerged) STL branch https://github.com/QuLogic/jot-lib/tree/STL.

[QuLogic]

Yes, @tombsar is correct. In general, I'd recommend using the STL branch as it seems to actually load things now.

[pKrime]

Thank you very much, I haven't checked the branches yet.

[pKrime]

So, I did checkout the STL branch and had some issues compiling:

in src/tess/bcurve.H at line 228, Wvec vector() seems to conflict with standard vector(), I changed to another name here and in bcurve.C, and it seems to work.

Then building stopped at /src/convert/iv2sm.C, complaining about not being able to handle the cycle

for (vector i = 0; i < tris.size(); i++)

I can't understand how this loop is supposed to work, yet it looks like vector hasn't got any int based constructor.

I just opted for a common

for (int i = 0; i < tris.size(); i++)

like in master, and could finally build and execute.

Actually I don't know what I should expect the program to do, so I can't say wether it worked or not. And again, I have no C++ experience, so I apologize if I wrote weird stuff.

I didn't notice differences in behaviour between master and STL version, I can load objects but can't draw on them.

Thanks

[QuLogic]

in src/tess/bcurve.H at line 228, Wvec vector() seems to conflict with standard vector(), I changed to another name here and in bcurve.C, and it seems to work.

Hmm, you're right. This used to work, but it seems the newer compiler is stricter. Not too hard to fix though.

Then building stopped at /src/convert/iv2sm.C, complaining about not being able to handle the cycle

for (vector i = 0; i < tris.size(); i++)

That should be vector<Triangle>::size_type.

Actually I don't know what I should expect the program to do, so I can't say wether it worked or not. And again, I have no C++ experience, so I apologize if I wrote weird stuff.

Oh, well, neither do I. 😄

I didn't notice differences in behaviour between master and STL version, I can load objects but can't draw on them.

You'll probably want to change the drawing mode. Drawing does something for me, but I don't know that it's working correctly just yet.

Unfortunately, I haven't had much time to work on this recently. Hopefully I'll have a chance to work on it some more.