Skip to content

Commit 85858ce

Browse files
committed
properly apply inputTZ option
1 parent 76617fb commit 85858ce

File tree

6 files changed

+16
-9
lines changed

6 files changed

+16
-9
lines changed

src/js/charts/cb-xy/parse-xy.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,17 @@ function parseXY(config, _chartProps, callback, parseOpts) {
2323
// clone so that we aren't modifying original
2424
// this can probably be avoided by applying new settings differently
2525
var chartProps = JSON.parse(JSON.stringify(_chartProps));
26+
2627
var bySeries = dataBySeries(chartProps.input.raw, {
2728
checkForDate: true,
2829
type: chartProps.input.type,
29-
inputTZ: chartProps.input.inputTZ
30+
inputTZ: (function() {
31+
if (chartProps.scale.dateSettings) {
32+
return chartProps.scale.dateSettings.inputTZ;
33+
} else {
34+
return "Z";
35+
}
36+
})()
3037
});
3138

3239
var labels = chartProps._annotations.labels;

src/js/components/chart-grid/ChartGridXY.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,8 @@ function drawXYChartGrid(el, state) {
372372
var inputOffset = state.chartProps.scale.dateSettings.inputTZ ? -help.TZOffsetToMinutes(state.chartProps.scale.dateSettings.inputTZ) : curOffset;
373373
var timeOffset = 0;
374374
axis.tickFormat(function(d,i) {
375-
if(displayTZ === "localized") {
376-
timeOffset = inputOffset - curOffset;
375+
if(displayTZ === "as-entered") {
376+
timeOffset = curOffset - inputOffset;
377377
}
378378

379379
return dateSettings.dateFormatter(d.clone(),i,timeOffset);

src/js/components/chart-xy/XYRenderer.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -759,8 +759,8 @@ function drawXY(el, state) {
759759
var inputOffset = state.chartProps.scale.dateSettings.inputTZ ? -help.TZOffsetToMinutes(state.chartProps.scale.dateSettings.inputTZ) : curOffset;
760760
var timeOffset = 0;
761761
axis.tickFormat(function(d,i) {
762-
if (displayTZ === "localized") {
763-
timeOffset = inputOffset - curOffset;
762+
if (displayTZ === "as-entered") {
763+
timeOffset = curOffset - inputOffset;
764764
}
765765
return dateSettings.dateFormatter(d.clone(),i,timeOffset);
766766
});

src/js/stores/SessionStore.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ var _session = {
1010
separators: detectNumberSeparators(),
1111
emSize: 10,
1212
width: 640,
13-
timerOn: function() {
13+
timerOn: (function() {
1414
if (localStorage) return ( localStorage.hasOwnProperty("model") === true );
1515
return false;
16-
},
16+
})(),
1717
nowOffset: getTZOffset(now),
1818
now: now
1919
};

src/js/util/helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ function merge_or_apply(defaults, source) {
216216
}
217217

218218
/**
219-
* Given a the domain of a scale suggest the most numerous number
219+
* Given a the domain of a scale suggest the most numerous number
220220
* of round number ticks that it cold be divided into while still containing
221221
values evenly divisible by 1, 2, 2.5, 5, 10, or 25.
222222
* @param {array} domain - An array of two number like objects

src/js/util/parse-delimited-input.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ function cast_data(input, columnNames, stripCharsRegex, opts) {
101101
var all_entry_values = [];
102102

103103
var found_timezones = tz_pattern.test(input);
104+
var offset = opts.inputTZ !== null ? -help.TZOffsetToMinutes(opts.inputTZ) : curOffset;
104105

105106
var data = dsv.parse(input, function(d,ii) {
106-
var offset = opts.inputTZ !== null ? -help.TZOffsetToMinutes(opts.inputTZ) : curOffset;
107107
each(columnNames, function(column, i) {
108108
if (i === 0) {
109109
//first column

0 commit comments

Comments
 (0)