vmupdate: expire cache + correct option name

expiring cache enforces re-downloading metadata
skip_unavailable -> skip_if_unavailable

skip_unavailable: skips unavailable packages
skip_if_unavailable: skips unavailable repos

Author: piotrbartman

vmupdate/agent/source/dnf/dnf5_api.py

@@ -21,6 +21,7 @@
 # USA.
 
 import subprocess
+import os
 
 import libdnf5
 from libdnf5.repo import DownloadCallbacks
@@ -57,11 +58,14 @@ def refresh(self, hard_fail: bool) -> ProcessResult:
         :param hard_fail: raise error if some repo is unavailable
         :return: (exit_code, stdout, stderr)
         """
-        self.config.skip_unavailable = not hard_fail
+        self.config.skip_if_unavailable = not hard_fail
 
         result = ProcessResult()
         try:
             self.log.debug("Refreshing available packages...")
+
+            result += self.expire_cache()
+
             repo_sack = self.base.get_repo_sack()
             repo_sack.create_repos_from_system_configuration()
             repo_sack.load_repos()

vmupdate/agent/source/dnf/dnf_cli.py

@@ -48,11 +48,7 @@ def refresh(self, hard_fail: bool) -> ProcessResult:
         :param hard_fail: raise error if some repo is unavailable
         :return: (exit_code, stdout, stderr)
         """
-        cmd = [self.package_manager,
-               "-q",
-               "clean",
-               "expire-cache"]
-        result = self.run_cmd(cmd)
+        result = self.expire_cache()
 
         cmd = [self.package_manager,
                "-q",
@@ -67,6 +63,17 @@ def refresh(self, hard_fail: bool) -> ProcessResult:
 
         return result
 
+    def expire_cache(self) -> ProcessResult:
+        """
+        Use package manager to expire cache.
+        """
+        cmd = [self.package_manager,
+               "-q",
+               "clean",
+               "expire-cache"]
+        result = self.run_cmd(cmd)
+        return result
+
     def get_packages(self):
         """
         Use rpm to return the installed packages and their versions.