chore: remove noScriptHere counter

Varixo · Varixo · commit 0b2db417b1cb · 2025-11-04T19:53:18.000+01:00
diff --git a/packages/qwik/src/server/ssr-container.ts b/packages/qwik/src/server/ssr-container.ts
@@ -350,8 +350,6 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
   openContainer() {
     if (this.tag == 'html') {
       this.write('<!DOCTYPE html>');
-      // -1 so we only emit inside body
-      this.$noScriptHere$ = -1;
     }
 
     const containerAttributes = this.renderOptions.containerAttributes || {};
@@ -383,7 +381,6 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
     return this.closeElement();
   }
 
-  // -1 so we only emit inside body
   private $noScriptHere$: number = 0;
 
   /** Renders opening tag for DOM element */
@@ -402,12 +399,12 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
       !isQwikStyle &&
       this.qlInclude === QwikLoaderInclude.Inline
     ) {
-      if (this.$noScriptHere$ === 0 && this.size > 30 * 1024) {
+      if (this.$noScriptHere$ === 0 && this.size > 30 * 1024 && elementName !== 'body') {
         // We waited long enough, on slow connections the page is already partially visible
         this.emitQwikLoaderInline();
       }
       // keep track of noscript and template, and for html we only emit inside body
-      else if (elementName === 'noscript' || elementName === 'template' || elementName === 'body') {
+      else if (elementName === 'noscript' || elementName === 'template') {
         this.$noScriptHere$++;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -350,8 +350,6 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {`
`350`	`350`	`openContainer() {`
`351`	`351`	`if (this.tag == 'html') {`
`352`	`352`	`this.write('<!DOCTYPE html>');`
`353`		`- // -1 so we only emit inside body`
`354`		`- this.$noScriptHere$ = -1;`
`355`	`353`	`}`
`356`	`354`
`357`	`355`	`const containerAttributes = this.renderOptions.containerAttributes \|\| {};`
`@@ -383,7 +381,6 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {`
`383`	`381`	`return this.closeElement();`
`384`	`382`	`}`
`385`	`383`
`386`		`- // -1 so we only emit inside body`
`387`	`384`	`private $noScriptHere$: number = 0;`
`388`	`385`
`389`	`386`	`/** Renders opening tag for DOM element */`
`@@ -402,12 +399,12 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {`
`402`	`399`	`!isQwikStyle &&`
`403`	`400`	`this.qlInclude === QwikLoaderInclude.Inline`
`404`	`401`	`) {`
`405`		`- if (this.$noScriptHere$ === 0 && this.size > 30 * 1024) {`
	`402`	`+ if (this.$noScriptHere$ === 0 && this.size > 30 * 1024 && elementName !== 'body') {`
`406`	`403`	`// We waited long enough, on slow connections the page is already partially visible`
`407`	`404`	`this.emitQwikLoaderInline();`
`408`	`405`	`}`
`409`	`406`	`// keep track of noscript and template, and for html we only emit inside body`
`410`		`- else if (elementName === 'noscript' \|\| elementName === 'template' \|\| elementName === 'body') {`
	`407`	`+ else if (elementName === 'noscript' \|\| elementName === 'template') {`
`411`	`408`	`this.$noScriptHere$++;`
`412`	`409`	`}`
`413`	`410`	`}`