Caching search results

[rroblik]

Hi,

Thanks for all the work done on restful module and on this restful_search_api module :)

I see that restful module provide storage capabilities which are not used in restful_search_api and I think that is a huge performance issue ...
The setRenderedCache() function (from RestfulBase.php) is never called.

I think the best place to add cache logic is in public function view($id) method isn't it ?

Thanks

[rroblik]

Ok I made a "workaround"

class RestfulSearchAPIMySearchClass extends \RestfulDataProviderSearchAPI implements \RestfulInterface {

// ...

public function view($id) {
    // To generate an unique cache id
    $cache_context = array(
      'search_keywords' => $id
    );

    $cached_data = $this->getRenderedCache($cache_context);
    if (!empty($cached_data->data)) {
      $output = $cached_data->data;
    }
    else {
      $output = parent::view($id);

      if (!empty($output)) {
        $this->setRenderedCache($output, $cache_context);
      }
    }


    return $output;
  }

// ...

But this is not perfect because the try ... catch done in RestfulDataProviderSearchAPI\view($id) can be made too late (done after checking for cache).

To my mind the RestfulDataProviderSearchAPI\view($id) should be improved to use caching. :)