diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000..6dac1c4 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,68 @@ +language: java +sudo: false +matrix: + include: + - os: osx + osx_image: xcode10 +install: + # Install Oracle JDK 10 and set as JAVA_HOME + - pwd + - cd .. + - mkdir java + - cd java + - wget http://www.nerps.net/jdk10/jdk-10.0.2_osx-x64_bin.dmg + - MOUNTDEV=$(hdiutil mount jdk-10.0.2_osx-x64_bin.dmg | awk '/dev.disk/{print$1}') + - echo $MOUNTDEV + - MOUNTDIR="$(mount | grep JDK | awk '{$1=$2="";sub(" [(].*","");sub("^ ","");print}')" + - echo $MOUNTDIR + - sudo installer -pkg "${MOUNTDIR}/"*.pkg -target / + - hdiutil unmount "$MOUNTDIR" + - echo java home was $JAVA_HOME + - export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home + - echo java home is $JAVA_HOME + - export PATH=$JAVA_HOME/bin:$PATH + - echo $PATH + - cd ../clientserver + - ./gradlew -version + - java -version +script: + - ./gradlew build +before_deploy: + # # Install Sentry.io CLI + # - curl -sL https://sentry.io/get-cli/ | bash + # - sentry-cli info + - echo Version is $TRAVIS_TAG + # # Create a Sentry release + # - sentry-cli releases new "$TRAVIS_TAG" + # Create Deploy Artifacts + - ./gradlew deploy +deploy: + provider: releases + api_key: $GITHUB_RELEASE_KEY + file_glob: true + file: releases/release-*/* + overwrite: true + skip_cleanup: true + target_commitish: $TRAVIS_COMMIT + tag_name: $TRAVIS_TAG + draft: false + prerelease: true + on: + repo: $REPO + tags: true + all_branches: true +after_deploy: +# Finalize Sentry release +# - sentry-cli releases finalize "$TRAVIS_TAG" +# Associate commits with the Sentry release +# - sentry-cli releases set-commits "$TRAVIS_TAG" --auto +# Tell Sentry.io we have deployed a release +# - sentry-cli releases deploys "$TRAVIS_TAG" new -e Production +after_success: + - wget $TRAVIS_DISCORD_WEBHOOK_SCRIPT_URL + - chmod +x send.sh + - ./send.sh success $DISCORD_URL +after_failure: + - wget $TRAVIS_DISCORD_WEBHOOK_SCRIPT_URL + - chmod +x send.sh + - ./send.sh failure $DISCORD_URL diff --git a/build.gradle b/build.gradle index 91916c1..cfe2919 100755 --- a/build.gradle +++ b/build.gradle @@ -1,16 +1,27 @@ -import org.apache.tools.ant.filters.ReplaceTokens import java.text.SimpleDateFormat -import org.ajoberstar.grgit.* +buildscript { + dependencies { + classpath "com.diffplug.spotless:spotless-plugin-gradle:3.26.1" + classpath "org.ajoberstar.grgit:grgit-gradle:4.0.1" + } + repositories { + mavenCentral() + jcenter() + maven { url 'https://plugins.gradle.org/m2/' } + } +} +plugins { + id "org.ajoberstar.grgit" version "4.0.1" + id "com.github.spotbugs" version "3.0.0" +} apply plugin: 'java' -apply plugin: 'findbugs' apply plugin: 'pmd' apply plugin: 'maven' apply plugin: 'com.diffplug.gradle.spotless' - sourceCompatibility = 1.7 targetCompatibility = 1.7 @@ -18,12 +29,11 @@ if (version == 'unspecified') { version = getVersionName() } -ext.repo = Grgit.open(project.file('.')) - +ext.repo = grgit.open(currentDir: project.file('.')) spotless { java { - eclipseFormatFile 'build-resources/eclipse.prefs.formatter.xml' + eclipse().configFile 'build-resources/eclipse.prefs.formatter.xml' } } @@ -33,54 +43,36 @@ configurations { } -task wrapper(type: Wrapper) { - gradleVersion='2.1' -} - install { repositories.mavenInstaller { - pom.version = project.version; - pom.artifactId = 'clientserver'; - pom.groupId = 'net.rptools.clientserver'; + pom.version = project.version + pom.artifactId = 'clientserver' + pom.groupId = 'net.rptools.clientserver' } } uploadArchives { repositories.mavenDeployer { - pom.version = project.version; - pom.artifactId = 'clientserver'; - pom.groupId = 'net.rptools.clientserver'; - configuration = configurations.deployerJars; + pom.version = project.version + pom.artifactId = 'clientserver' + pom.groupId = 'net.rptools.clientserver' + configuration = configurations.deployerJars repository url: 'file://' + projectDir + '/../maven-repo' } } -buildscript { - repositories { - mavenCentral() - jcenter() - maven { - url 'https://plugins.gradle.org/m2/' - } - } - dependencies { - classpath 'org.ajoberstar:gradle-git:0.11.2' - classpath 'com.diffplug.gradle.spotless:spotless:1.3.0-SNAPSHOT' - } -} - dependencies { - compile 'commons-logging:commons-logging:1.1.1' - compile 'log4j:log4j:1.2.16' - compile 'com.caucho.hessian:hessian:3.1.6' + implementation 'commons-logging:commons-logging:1.1.1' + implementation 'log4j:log4j:1.2.16' + implementation 'com.caucho.hessian:hessian:3.1.6' testCompile group: 'junit', name: 'junit', version: '4.11' deployerJars 'org.apache.maven.wagon:wagon-ssh:2.2' } -ext.compileDate = new Date(); -ext.yyyymmdd = (new SimpleDateFormat('yyyyMMDD')).format(ext.compileDate); +ext.compileDate = new Date() +ext.yyyymmdd = (new SimpleDateFormat('yyyyMMDD')).format((Date)ext.compileDate) repositories { @@ -107,9 +99,9 @@ def getVersionName() { } } -findbugs { +spotbugs { ignoreFailures = true - toolVersion = '3.0.0' + toolVersion = '3.1.12' effort = 'max' sourceSets = [] // Empty source set so it wont run during build/check } @@ -119,16 +111,16 @@ pmd { sourceSets = [] // Empty source set so it wont run during tebuild/check } - - -task showBuildVersion() << { - println 'Build Version Number = ' + project.version +task showBuildVersion() { + doLast { + println 'Build Version Number = ' + project.version + } } jar { manifest { attributes 'Implementation-Title': 'clientserver', - 'Implementation-Version': project.version + 'Implementation-Version': project.version } } diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index b5166da..5c2d1cf 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index db897ff..51fb1c4 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,5 @@ -#Fri Sep 18 13:53:52 ACST 2015 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-5.3.1-all.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-2.1-bin.zip diff --git a/gradlew b/gradlew index 91a7e26..b0d6d0a 100755 --- a/gradlew +++ b/gradlew @@ -1,4 +1,20 @@ -#!/usr/bin/env bash +#!/usr/bin/env sh + +# +# Copyright 2015 the original author or authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ############################################################################## ## @@ -6,20 +22,38 @@ ## ############################################################################## -# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -DEFAULT_JVM_OPTS="" +# Attempt to set APP_HOME +# Resolve links: $0 may be a link +PRG="$0" +# Need this for relative symlinks. +while [ -h "$PRG" ] ; do + ls=`ls -ld "$PRG"` + link=`expr "$ls" : '.*-> \(.*\)$'` + if expr "$link" : '/.*' > /dev/null; then + PRG="$link" + else + PRG=`dirname "$PRG"`"/$link" + fi +done +SAVED="`pwd`" +cd "`dirname \"$PRG\"`/" >/dev/null +APP_HOME="`pwd -P`" +cd "$SAVED" >/dev/null APP_NAME="Gradle" APP_BASE_NAME=`basename "$0"` +# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' + # Use the maximum available, or set MAX_FD != -1 to use that value. MAX_FD="maximum" -warn ( ) { +warn () { echo "$*" } -die ( ) { +die () { echo echo "$*" echo @@ -30,6 +64,7 @@ die ( ) { cygwin=false msys=false darwin=false +nonstop=false case "`uname`" in CYGWIN* ) cygwin=true @@ -40,31 +75,11 @@ case "`uname`" in MINGW* ) msys=true ;; + NONSTOP* ) + nonstop=true + ;; esac -# For Cygwin, ensure paths are in UNIX format before anything is touched. -if $cygwin ; then - [ -n "$JAVA_HOME" ] && JAVA_HOME=`cygpath --unix "$JAVA_HOME"` -fi - -# Attempt to set APP_HOME -# Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi -done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >&- -APP_HOME="`pwd -P`" -cd "$SAVED" >&- - CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar # Determine the Java command to use to start the JVM. @@ -90,7 +105,7 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" ] ; then +if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then MAX_FD_LIMIT=`ulimit -H -n` if [ $? -eq 0 ] ; then if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then @@ -114,6 +129,7 @@ fi if $cygwin ; then APP_HOME=`cygpath --path --mixed "$APP_HOME"` CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` + JAVACMD=`cygpath --unix "$JAVACMD"` # We build the pattern for arguments to be converted via cygpath ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` @@ -154,11 +170,19 @@ if $cygwin ; then esac fi -# Split up the JVM_OPTS And GRADLE_OPTS values into an array, following the shell quoting and substitution rules -function splitJvmOpts() { - JVM_OPTS=("$@") +# Escape application args +save () { + for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done + echo " " } -eval splitJvmOpts $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS -JVM_OPTS[${#JVM_OPTS[*]}]="-Dorg.gradle.appname=$APP_BASE_NAME" +APP_ARGS=$(save "$@") + +# Collect all arguments for the java command, following the shell quoting and substitution rules +eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" + +# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong +if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then + cd "$(dirname "$0")" +fi -exec "$JAVACMD" "${JVM_OPTS[@]}" -classpath "$CLASSPATH" org.gradle.wrapper.GradleWrapperMain "$@" +exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index aec9973..15e1ee3 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -1,3 +1,19 @@ +@rem +@rem Copyright 2015 the original author or authors. +@rem +@rem Licensed under the Apache License, Version 2.0 (the "License"); +@rem you may not use this file except in compliance with the License. +@rem You may obtain a copy of the License at +@rem +@rem http://www.apache.org/licenses/LICENSE-2.0 +@rem +@rem Unless required by applicable law or agreed to in writing, software +@rem distributed under the License is distributed on an "AS IS" BASIS, +@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +@rem See the License for the specific language governing permissions and +@rem limitations under the License. +@rem + @if "%DEBUG%" == "" @echo off @rem ########################################################################## @rem @@ -8,14 +24,14 @@ @rem Set local scope for the variables with windows NT shell if "%OS%"=="Windows_NT" setlocal -@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -set DEFAULT_JVM_OPTS= - set DIRNAME=%~dp0 if "%DIRNAME%" == "" set DIRNAME=. set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% +@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m" + @rem Find java.exe if defined JAVA_HOME goto findJavaFromJavaHome @@ -46,10 +62,9 @@ echo location of your Java installation. goto fail :init -@rem Get command-line arguments, handling Windowz variants +@rem Get command-line arguments, handling Windows variants if not "%OS%" == "Windows_NT" goto win9xME_args -if "%@eval[2+2]" == "4" goto 4NT_args :win9xME_args @rem Slurp the command line arguments. @@ -60,11 +75,6 @@ set _SKIP=2 if "x%~1" == "x" goto execute set CMD_LINE_ARGS=%* -goto execute - -:4NT_args -@rem Get arguments from the 4NT Shell from JP Software -set CMD_LINE_ARGS=%$ :execute @rem Setup the command line diff --git a/src/main/java/net/rptools/clientserver/ActivityListener.java b/src/main/java/net/rptools/clientserver/ActivityListener.java index ba1f987..8a88b38 100644 --- a/src/main/java/net/rptools/clientserver/ActivityListener.java +++ b/src/main/java/net/rptools/clientserver/ActivityListener.java @@ -16,8 +16,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to - * Window - Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public interface ActivityListener { public static enum Direction { diff --git a/src/main/java/net/rptools/clientserver/hessian/AbstractMethodHandler.java b/src/main/java/net/rptools/clientserver/hessian/AbstractMethodHandler.java index 208897a..dc4f12c 100644 --- a/src/main/java/net/rptools/clientserver/hessian/AbstractMethodHandler.java +++ b/src/main/java/net/rptools/clientserver/hessian/AbstractMethodHandler.java @@ -24,13 +24,16 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to - * Window - Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public abstract class AbstractMethodHandler implements MethodHandler { - /* (non-Javadoc) - * @see clientserver.simple.MessageHandler#handleMessage(java.lang.String, byte[]) + /* + * (non-Javadoc) + * + * @see clientserver.simple.MessageHandler#handleMessage(java.lang.String, + * byte[]) */ public void handleMessage(String id, byte[] message) { try { diff --git a/src/main/java/net/rptools/clientserver/hessian/HessianUtils.java b/src/main/java/net/rptools/clientserver/hessian/HessianUtils.java index e3e1e05..24517a8 100644 --- a/src/main/java/net/rptools/clientserver/hessian/HessianUtils.java +++ b/src/main/java/net/rptools/clientserver/hessian/HessianUtils.java @@ -22,8 +22,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to - * Window - Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public class HessianUtils { public static final byte[] methodToBytes(String method, Object... parameters) { diff --git a/src/main/java/net/rptools/clientserver/hessian/MethodHandler.java b/src/main/java/net/rptools/clientserver/hessian/MethodHandler.java index 167586b..bc31abe 100644 --- a/src/main/java/net/rptools/clientserver/hessian/MethodHandler.java +++ b/src/main/java/net/rptools/clientserver/hessian/MethodHandler.java @@ -18,8 +18,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to - * Window - Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public interface MethodHandler extends MessageHandler { diff --git a/src/main/java/net/rptools/clientserver/simple/AbstractConnection.java b/src/main/java/net/rptools/clientserver/simple/AbstractConnection.java index b4c638b..f291cd2 100644 --- a/src/main/java/net/rptools/clientserver/simple/AbstractConnection.java +++ b/src/main/java/net/rptools/clientserver/simple/AbstractConnection.java @@ -31,8 +31,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to Window - Preferences - Java - Code Style - - * Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public abstract class AbstractConnection { // We don't need to make each list synchronized since the class is synchronized diff --git a/src/main/java/net/rptools/clientserver/simple/MessageHandler.java b/src/main/java/net/rptools/clientserver/simple/MessageHandler.java index fc366a5..1c074e9 100644 --- a/src/main/java/net/rptools/clientserver/simple/MessageHandler.java +++ b/src/main/java/net/rptools/clientserver/simple/MessageHandler.java @@ -16,8 +16,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to - * Window - Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public interface MessageHandler { diff --git a/src/main/java/net/rptools/clientserver/simple/client/ClientConnection.java b/src/main/java/net/rptools/clientserver/simple/client/ClientConnection.java index 6102c4d..947abd7 100644 --- a/src/main/java/net/rptools/clientserver/simple/client/ClientConnection.java +++ b/src/main/java/net/rptools/clientserver/simple/client/ClientConnection.java @@ -25,8 +25,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to Window - Preferences - Java - Code Style - - * Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public class ClientConnection extends AbstractConnection { private final Socket socket; diff --git a/src/main/java/net/rptools/clientserver/simple/server/ServerConnection.java b/src/main/java/net/rptools/clientserver/simple/server/ServerConnection.java index 3f70444..286568c 100644 --- a/src/main/java/net/rptools/clientserver/simple/server/ServerConnection.java +++ b/src/main/java/net/rptools/clientserver/simple/server/ServerConnection.java @@ -101,8 +101,9 @@ public void sendMessage(String id, Object channel, byte[] message) { } /** - * Server subclasses may override this method to perform serial handshaking before the connection is accepted into - * its pool. By default, this just returns true. + * Server subclasses may override this method to perform serial handshaking + * before the connection is accepted into its pool. By default, this just + * returns true. * * @param conn * @return true if the connection should be added to the pool diff --git a/src/test/java/net/rptools/clientserver/Test01.java b/src/test/java/net/rptools/clientserver/Test01.java index 775912d..72c8c28 100644 --- a/src/test/java/net/rptools/clientserver/Test01.java +++ b/src/test/java/net/rptools/clientserver/Test01.java @@ -25,8 +25,8 @@ /** * @author drice * - * TODO To change the template for this generated type comment go to Window - - * Preferences - Java - Code Style - Code Templates + * TODO To change the template for this generated type comment go to + * Window - Preferences - Java - Code Style - Code Templates */ public class Test01 {