[Bug]: Impossible to display stats from unowned NPC tokens on custom stat sheets

[pizzystrizzy]

Describe the Bug

On custom stat sheets, but not the old default stat sheet, if a token has the type NPC, and is unowned by the players, properties that are supposed to show on the stat sheet to non-owners and non-GMs will not display. This also prevents the portrait from displaying. With the default stat sheet, as long as one property is visible to players, the portrait is also visible.

To Reproduce

Use a custom stat sheet. Designate a property as appearing on the stat sheet while leaving GM and owner unchecked. Log in with a player client that does not own the token, and mouse over the token.

Expected Behaviour

The expected behavior is that stats designated to show to non-GM non-owners will in fact show to non-GM non-owners.

Screenshots

No response

MapTool Info

1.18.6

Desktop

any

Additional Context

I believe this is due to the condition in statsheetlistener.java,

 if (MapTool.getPlayer().isGM()
            || AppUtil.playerOwns(token)
            || token.getType() != Type.NPC) {
          statSheet.setContent(

I believe if that entire condition is deleted, then the custom stat sheet will behave correctly like the default stat sheet.

In case anyone likes for this bug to persist because they don't want to reveal NPC properties to players, they could just use an NPC property type and restrict the property to GMs, so there's really no rational basis to not fix this bug.

[bubblobill]

#5887