Reorganize Group names in build system for clarity and IDE integration #10923
+84
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…iler→Libc Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor groups for basic system organization
Reorganize Group names in build system for clarity and IDE integration
Nov 11, 2025
Copilot finished work on behalf of
BernardXiong
November 11, 2025 21:01
github-actions
bot
added
Kernel
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_libcReviewers: GorrayLi mysterywolf Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-11-12 05:14 CST)
📝 Review Instructions
|
| src += Glob('platform/rtthread/usb_check.c') | ||
|
|
||
| group = DefineGroup('CherryUSB', src, depend = ['RT_USING_CHERRYUSB'], LIBS = LIBS, LIBPATH=LIBPATH, CPPPATH = path, CPPDEFINES = CPPDEFINES) | ||
| group = DefineGroup('DeviceDrivers', src, depend = ['RT_USING_CHERRYUSB'], LIBS = LIBS, LIBPATH=LIBPATH, CPPPATH = path, CPPDEFINES = CPPDEFINES) |
Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Copilot finished work on behalf of
BernardXiong
November 11, 2025 21:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
为什么提交这份PR (why to submit this PR)
当前基础系统（Kernel, shell, libc/posix, file system, network stack, device subsystem）的Group划分显得很乱，很随意，需要对这些Group划分进行整理，变得简单清晰。Group名称会在一些IDE中作为分类组出现，因此需要简洁、分类清晰、条理清晰。
你的解决方案是什么 (what is your solution)
统一规范化基础系统的Group命名：
基础系统组重命名：
klibc→Libc(kernel libc, 1个文件)libcpu→CPU(所有CPU架构, 56个文件)mm→Memm(内存管理, 1个文件)POSIX→Libc(POSIX接口, 15个文件)Compiler→Libc(编译器支持, 9个文件)设备驱动统一化：
ktime→DeviceDrivers(1个文件)CherryUSB→UsbStack(1个文件，USB协议栈独立分组)DeviceDrivers(48个文件)影响范围：
DefineGroup()的字符串参数，无功能性改变重组后的Group结构：
Libc,KernelCPUMemmDeviceDriversUsbStackFilesystemlwIP,SAL,AT请提供验证的bsp和config (provide the config and bsp)
BSP: bsp/qemu-virt64-aarch64
.config: 默认配置
action: 构建系统dry-run测试通过
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned upFixes #10904
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.