I was just playing around with this and could take it a bit further. These were the adoptions I made:

Change Electron build command to consider electron builder config
Running npm exec electron-builder --linux is not working correctly as it doesn't take into account electron-builder.config.js. So, instead I ran npm run package. However, as there is also a prepackage script in package.json which is automatically executed and contains npm run build which finishes with errors, the actual package script was never executed. What worked was to remove prepackage from npm scripts in package.json. Then I ran npm run build separately, let it finish with errors and then ran npm run package.
Fixing icon directory doesn't contain icons error
When running npm run package for the first time I ran into the mentioned error. The fix was fairly simple. I just copied assets/icon.png to assets/icons/icon.png. Then ran npm run build again and npm run package. This successfully builds the AppImage.

Note, that as per electron config the AppImage will be located in release/build-linux-x64-reg. From there it can be executed. Also, the Module not found error isn't present anymore when building the app like this.
Fixing RABBY_DESKTOP_KR_PWD not found
When running the AppImage the first time, I ran into the mentioned error. I could fix this by adopting _base.ts by changing this

// export const RABBY_DESKTOP_KR_PWD = '<set password here>';
export const RABBY_DESKTOP_KR_PWD = IS_RUNTIME_PRODUCTION
  ? (process as any).RABBY_DESKTOP_KR_PWD!
  : process.env.RABBY_DESKTOP_KR_PWD;`

to that

export const RABBY_DESKTOP_KR_PWD = 'mypwd';
//export const RABBY_DESKTOP_KR_PWD = IS_RUNTIME_PRODUCTION
//  ? (process as any).RABBY_DESKTOP_KR_PWD!
//  : process.env.RABBY_DESKTOP_KR_PWD;`

Then ran npm run build again and npm run package.

Fixing /bin/sh: 1: scutil: not found error
When running the AppImage again, this error was thrown Error: Command failed: scutil --proxy. I investigated the source code a bit and figured that this is somehow expected as proxy settings are retrieved differently on operating systems. In systemConfig.ts there are two functions getDarwinSystemHttpProxySettings() for macOS and getWin32SystemHttpProxySettings() for Windows.

To fix the error I added this var const isLinux = process.platform === 'linux'; and this function async function getLinuxSystemHttpProxySettings(): Promise<ISimpleProxySetting | null> { return null; } and adopted result.config to result.config = isWin32 ? await getWin32SystemHttpProxySettings() : isLinux ? await getLinuxSystemHttpProxySettings() : await getDarwinSystemHttpProxySettings();. So the whole systemConfig.ts file looks like this:

import child_process from 'child_process';

import {
  type ProxySetting,
  type Protocol,
  getProxyWindows,
} from 'get-proxy-settings';

import { coerceNumber } from '@/isomorphic/primitive';
import { parseScUtilProxyOutput } from '@/isomorphic/parser';

const isWin32 = process.platform === 'win32';
const isLinux = process.platform === 'linux';

const command = 'scutil --proxy';

type ISimpleProxySetting = {
  host: ProxySetting['host'];
  port: ProxySetting['port'] | number;
  protocol: ProxySetting['protocol'];
  // TODO: use those two fields in proper case if provided
  credentials?: ProxySetting['credentials'];
  bypassAddrs?: string[];
};

async function getDarwinSystemHttpProxySettings(): Promise<ISimpleProxySetting | null> {
  try {
    const output = child_process.execSync(command);
    const settings = parseScUtilProxyOutput(output.toString());

    if (settings.HTTPEnable) {
      return {
        protocol: 'http' as Protocol,
        host: settings.HTTPProxy as string,
        port: settings.HTTPPort as number,
      };
    }
    if (settings.HTTPSEnable) {
      return {
        protocol: 'http' as Protocol,
        host: settings.HTTPSProxy as string,
        port: settings.HTTPSPort as number,
      };
    } /* else if (settings.SOCKSEnable) {
      return {
        protocol: 'socks' as Protocol,
        host: settings.SOCKSProxy as string,
        port: settings.SOCKSPort as number,
      }
    } */
  } catch (err) {
    console.error(err);
  }

  return null;
}

async function getWin32SystemHttpProxySettings(): Promise<ISimpleProxySetting | null> {
  const settings = await getProxyWindows();

  return settings?.https || settings?.http || null;
}

async function getLinuxSystemHttpProxySettings(): Promise<ISimpleProxySetting | null> {
  // TODO: Implement
  return null;
}

export type ISysProxyInfo = {
  config: ISimpleProxySetting | null;
  systemProxySettings: IAppProxyConf['systemProxySettings'];
};
const state: {
  fetched: boolean;
  config: ISysProxyInfo['config'];
} = {
  fetched: false,
  config: null,
};
export async function getSystemProxyInfo(forceReload = false) {
  const result: ISysProxyInfo = {
    config: state.config ? { ...state.config } : null,
    systemProxySettings: undefined,
  };
  if (!state.fetched || forceReload) {
    result.config = isWin32
      ? await getWin32SystemHttpProxySettings()
      : isLinux ? await getLinuxSystemHttpProxySettings() : await getDarwinSystemHttpProxySettings();

    state.fetched = true;
  }

  if (result.config) {
    const port = coerceNumber(result.config.port, 0);

    result.systemProxySettings = {
      protocol: result.config.protocol as 'http',
      host: result.config.host,
      port,
    };
  } else {
    result.systemProxySettings = undefined;
  }

  return result;
}

Then ran npm run build again and npm run package. This fixes the error.

Running into error Extension directory not found
This is the complete error:

Error: Extension directory not found: /tmp/.mount_Rabby lIQBD2/resources/assets/desktop_shell
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: Extension directory not found: /tmp/.mount_Rabby lIQBD2/resources/assets/desktop_shell
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
[62356:0305/122423.748177:ERROR:nss_util.cc(357)] After loading Root Certs, loaded==false: NSS error code: -8018

Indeed, the desktop_shell directory isn't present. I saw that */desktop_shell/* is present in .gitignore. l checked the directory out in my Windows build and just copied it over to the repo's assets directory. Then ran npm run package again and executed the AppImage. This fixed the error. I was just wondering why */desktop_shell/* is not checked in to the repository. Basically it just contains some HTML, CSS and JS files and a bunch of svg icons for different chains / cryptocurrencies and a matomo client file. Any comments on that from the dev team?

Edit: Managed to get one step further from 5. to 6. 😄

Running into error Error: ERR_FILE_NOT_FOUND (-6) loading 'rabby-internal://local/popup-view.html#/rabby-notification-gasket'
This is the complete error:

(node:27658) electron: Failed to load URL: rabby-internal://local/popup-view.html#/rabby-notification-gasket with error: ERR_FILE_NOT_FOUND
10:03:35.034 › Error: ERR_FILE_NOT_FOUND (-6) loading 'rabby-internal://local/popup-view.html#/rabby-notification-gasket'
    at rejectAndCleanup (node:electron/js2c/browser_init:2:85498)
    at WebContents.failListener (node:electron/js2c/browser_init:2:85711)
    at WebContents.emit (node:events:513:28)
    at WebContents.emit (node:domain:489:12)
    at e.emit (/tmp/.mount_Rabby zBKxH7/resources/app.asar/dist/main/main.js:2:338379)
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: ERR_FILE_NOT_FOUND (-6) loading 'rabby-internal://local/popup-view.html#/rabby-notification-gasket'
    at rejectAndCleanup (node:electron/js2c/browser_init:2:85498)
    at WebContents.failListener (node:electron/js2c/browser_init:2:85711)
    at WebContents.emit (node:events:513:28)
    at WebContents.emit (node:domain:489:12)
    at e.emit (/tmp/.mount_Rabby zBKxH7/resources/app.asar/dist/main/main.js:2:338379)

With this one, I'm stuck. I didn't manage to fix it unfortunately. Would be amazing if someone from the dev team can comment on that. May be @richardo2016x ? Thank you.

Support for Linux #606

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions