Utilise Minutes in TempBan for under 1 hour bans. #362
Conversation
The duration calculation for tempbans now uses minutes rather than hours for greater precision. This change ensures better alignment with user expectations and configurations in smaller timeframes.
|
This works but wouldn't it also be great if the code that threw the exception got refactored in a way that the underlying cause stops throwing under some circumstances? Perhaps I'm not understanding the code right now |
|
@diamante0018 You're right. The underlying issues is still present. This fix was only for the webfront side. People could still use decimal in commands, but not sure why you would, but it's possible. :D |
|
I see. Ah I understand. Maybe I'll setup a server locally to check it out. Haven't wrote in c# in a while but if it's something I can do I'll make a pr |
|
I can fix it if necessary, it's no issue. We should probably just reject the command or use the fallback value if the duration contains a decimal place. |
Adjusted regex in `ParseTimespan` and `TempBanCommand` to ensure input starts with 1-5 numeric characters, improving validation. This prevents malformed user inputs and enhances overall command reliability.
|
Okay, this should input the issue too through regex constraints. If the regex can be bypassed, the Webfront now works with <1h durations. Manual commands are now properly constrained. Note, failing syntax will not return any message to the user. |
Previously, configurations with <1hr tempban period presets threw
int.Parse()floating point issues as it converted it to <1.This resolves this by utilising minutes as the smallest time step.