Skip to content

Critical Error in Distance Normalizations #2

@RandomKiddo

Description

@RandomKiddo

Distance normalization scale is off in the HackAI version, possibly causing the excess error in the distance calculation.

The lines

train_distances = (train_distances-np.min(train_distances))/(np.max(train_distances)-np.min(train_distances))
val_distances = (val_distances-np.min(val_distances))/(np.max(val_distances)-np.min(val_distances))
test_distances = (test_distances-np.min(test_distances))/(np.max(test_distances)-np.min(test_distances))

needs to be corrected to

max_distance = np.max(distances)
min_distance = np.min(distances)

train_distances = (train_distances-min_distance)/(max_distance-min_distance)
val_distances = (val_distances-min_distance)/(max_distance-min_distance)
test_distances = (test_distances-min_distance)/(max_distance-min_distance)

in the next version(s) of the model.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcriticalThis is high priority

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions