Better ordering of hit record in ray_color() func

Originally due to GitHub user @sshaplygin.

Author: hollasch

books/RayTracingInOneWeekend.html

@@ -2387,16 +2387,13 @@
         ...
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
         color ray_color(const ray& r, int depth, const hittable& world) const {
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
-            hit_record rec;
-
-
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
 
+            hit_record rec;
+
             if (world.hit(r, interval(0, infinity), rec)) {
                 vec3 direction = random_on_hemisphere(rec.normal);
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
@@ -2462,12 +2459,12 @@
       private:
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
 
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
             if (world.hit(r, interval(0.001, infinity), rec)) {
@@ -2533,12 +2530,12 @@
     class camera {
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             if (world.hit(r, interval(0.001, infinity), rec)) {
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
                 vec3 direction = rec.normal + random_unit_vector();
@@ -2594,12 +2591,12 @@
 class camera {
     ...
     color ray_color(const ray& r, int depth, const hittable& world) const {
-        hit_record rec;
-
         // If we've exceeded the ray bounce limit, no more light is gathered.
         if (depth <= 0)
             return color(0,0,0);
 
+        hit_record rec;
+
         if (world.hit(r, interval(0.001, infinity), rec)) {
             vec3 direction = rec.normal + random_unit_vector();
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
@@ -2983,12 +2980,12 @@
       private:
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             if (world.hit(r, interval(0.001, infinity), rec)) {
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
                 ray scattered;

books/RayTracingTheNextWeek.html

@@ -3126,12 +3126,12 @@
       private:
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
 
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
             // If the ray hits nothing, return the background color.

books/RayTracingTheRestOfYourLife.html

@@ -1677,12 +1677,12 @@
       private:
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             // If the ray hits nothing, return the background color.
             if (!world.hit(r, interval(0.001, infinity), rec))
                 return background;
@@ -2384,12 +2384,12 @@
       ...
       private:
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             // If the ray hits nothing, return the background color.
             if (!world.hit(r, interval(0.001, infinity), rec))
                 return background;
@@ -2609,12 +2609,12 @@
       private:
         ...
         color ray_color(const ray& r, int depth, const hittable& world) const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             // If the ray hits nothing, return the background color.
             if (!world.hit(r, interval(0.001, infinity), rec))
                 return background;
@@ -3204,12 +3204,12 @@
         ...
         color ray_color(const ray& r, int depth, const hittable& world, const hittable& lights)
         const {
-            hit_record rec;
-
             // If we've exceeded the ray bounce limit, no more light is gathered.
             if (depth <= 0)
                 return color(0,0,0);
 
+            hit_record rec;
+
             // If the ray hits nothing, return the background color.
             if (!world.hit(r, interval(0.001, infinity), rec))
                 return background;

src/TheRestOfYourLife/camera.h

@@ -144,12 +144,12 @@ class camera {
 
     color ray_color(const ray& r, int depth, const hittable& world, const hittable& lights)
     const {
-        hit_record rec;
-
         // If we've exceeded the ray bounce limit, no more light is gathered.
         if (depth <= 0)
             return color(0,0,0);
 
+        hit_record rec;
+
         // If the ray hits nothing, return the background color.
         if (!world.hit(r, interval(0.001, infinity), rec))
             return background;