Skip to content

Commit 4142b11

Browse files
committed
remove getInstance() factory method calls
1 parent 82bd8a6 commit 4142b11

File tree

12 files changed

+34
-34
lines changed

12 files changed

+34
-34
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ CompositeObservable<String> valueChanges = CompositeObservable<>(obs -> obs.repl
323323

324324
### JavaFX Scheduler
325325

326-
When you update any JavaFX control, it must be done on the JavaFX Event Dispatch Thread. Fortunately, the `JavaFxScheduler` makes it trivial to take work off the JavaFX thread and put it back when the results are ready. Below we can use the `observeOn()` to pass text value emissions to a computation thread where the text will be flipped. Then we can pass `JavaFxScheduler.getInstance()` to another `observeOn()` afterwards to put it back on the JavaFX thread. From there it will update the `flippedTextLabel`.
326+
When you update any JavaFX control, it must be done on the JavaFX Event Dispatch Thread. Fortunately, the `JavaFxScheduler` makes it trivial to take work off the JavaFX thread and put it back when the results are ready. Below we can use the `observeOn()` to pass text value emissions to a computation thread where the text will be flipped. Then we can pass `JavaFxScheduler.platform()` to another `observeOn()` afterwards to put it back on the JavaFX thread. From there it will update the `flippedTextLabel`.
327327

328328
```java
329329
TextField textInput = new TextField();
@@ -334,7 +334,7 @@ Observable<String> textInputs =
334334

335335
sub2 = textInputs.observeOn(Schedulers.computation())
336336
.map(s -> new StringBuilder(s).reverse().toString())
337-
.observeOn(JavaFxScheduler.getInstance())
337+
.observeOn(JavaFxScheduler.platform())
338338
.subscribe(fippedTextLabel::setText);
339339
```
340340

@@ -411,7 +411,7 @@ public class RxJavaFXTest extends Application {
411411

412412
binding2 = JavaFxSubscriber.toBinding(textInputs.observeOn(Schedulers.computation())
413413
.map(s -> new StringBuilder(s).reverse().toString())
414-
.observeOn(JavaFxScheduler.getInstance()));
414+
.observeOn(JavaFxScheduler.platform()));
415415

416416
flippedTextLabel.textProperty().bind(binding2);
417417

src/main/java/rx/javafx/sources/ActionEventSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static Observable<ActionEvent> fromActionEvents(final ContextMenu source)
3939
source.addEventHandler(ActionEvent.ANY, handler);
4040

4141
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeEventHandler(ActionEvent.ANY, handler)));
42-
}).subscribeOn(JavaFxScheduler.getInstance());
42+
}).subscribeOn(JavaFxScheduler.platform());
4343
}
4444
public static Observable<ActionEvent> fromActionEvents(final MenuItem source) {
4545
return Observable.create((ObservableEmitter<ActionEvent> subscriber) -> {
@@ -48,7 +48,7 @@ public static Observable<ActionEvent> fromActionEvents(final MenuItem source) {
4848
source.addEventHandler(ActionEvent.ANY, handler);
4949

5050
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeEventHandler(ActionEvent.ANY, handler)));
51-
}).subscribeOn(JavaFxScheduler.getInstance());
51+
}).subscribeOn(JavaFxScheduler.platform());
5252
}
5353

5454
}

src/main/java/rx/javafx/sources/DialogSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ private DialogSource() {}
1010

1111
public static <T> Observable<T> fromDialogSource(final Dialog<T> dialog) {
1212
return Observable.fromCallable(dialog::showAndWait)
13-
.subscribeOn(JavaFxScheduler.getInstance())
13+
.subscribeOn(JavaFxScheduler.platform())
1414
.filter(Optional::isPresent)
1515
.map(Optional::get);
1616
}

src/main/java/rx/javafx/sources/NodeEventSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ public static <T extends Event> Observable<T> fromNodeEvents(final Node source,
3333
source.addEventHandler(eventType, handler);
3434

3535
emitter.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeEventHandler(eventType, handler)));
36-
}).subscribeOn(JavaFxScheduler.getInstance());
36+
}).subscribeOn(JavaFxScheduler.platform());
3737
}
3838
}

src/main/java/rx/javafx/sources/ObservableListSource.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static <T> Observable<ObservableList<T>> fromObservableList(final Observa
3434
ListChangeListener<T> listener = c -> subscriber.onNext(source);
3535
source.addListener(listener);
3636
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
37-
}).startWith(source).subscribeOn(JavaFxScheduler.getInstance());
37+
}).startWith(source).subscribeOn(JavaFxScheduler.platform());
3838
}
3939

4040
public static <T> Observable<T> fromObservableListAdds(final ObservableList<T> source) {
@@ -51,7 +51,7 @@ public static <T> Observable<T> fromObservableListAdds(final ObservableList<T> s
5151
source.addListener(listener);
5252
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
5353

54-
}).subscribeOn(JavaFxScheduler.getInstance());
54+
}).subscribeOn(JavaFxScheduler.platform());
5555
}
5656
public static <T> Observable<T> fromObservableListRemovals(final ObservableList<T> source) {
5757

@@ -68,7 +68,7 @@ public static <T> Observable<T> fromObservableListRemovals(final ObservableList<
6868
source.addListener(listener);
6969
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
7070

71-
}).subscribeOn(JavaFxScheduler.getInstance());
71+
}).subscribeOn(JavaFxScheduler.platform());
7272
}
7373
public static <T> Observable<T> fromObservableListUpdates(final ObservableList<T> source) {
7474

@@ -86,7 +86,7 @@ public static <T> Observable<T> fromObservableListUpdates(final ObservableList<T
8686
source.addListener(listener);
8787
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
8888

89-
}).subscribeOn(JavaFxScheduler.getInstance());
89+
}).subscribeOn(JavaFxScheduler.platform());
9090
}
9191
public static <T> Observable<ListChange<T>> fromObservableListChanges(final ObservableList<T> source) {
9292
return Observable.create((ObservableOnSubscribe<ListChange<T>>) subscriber -> {
@@ -109,7 +109,7 @@ public static <T> Observable<ListChange<T>> fromObservableListChanges(final Obse
109109
source.addListener(listener);
110110

111111
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
112-
}).subscribeOn(JavaFxScheduler.getInstance());
112+
}).subscribeOn(JavaFxScheduler.platform());
113113
}
114114

115115
public static <T> Observable<ListChange<T>> fromObservableListDistinctChanges(final ObservableList<T> source) {
@@ -135,7 +135,7 @@ public static <T> Observable<ListChange<T>> fromObservableListDistinctChanges(fi
135135
source.addListener(listener);
136136

137137
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
138-
}).subscribeOn(JavaFxScheduler.getInstance());
138+
}).subscribeOn(JavaFxScheduler.platform());
139139
}
140140
public static <T,R> Observable<ListChange<T>> fromObservableListDistinctChanges(final ObservableList<T> source, Function<T,R> mapper) {
141141

@@ -159,7 +159,7 @@ public static <T,R> Observable<ListChange<T>> fromObservableListDistinctChanges(
159159
};
160160
source.addListener(listener);
161161
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
162-
}).subscribeOn(JavaFxScheduler.getInstance());
162+
}).subscribeOn(JavaFxScheduler.platform());
163163
}
164164
public static <T,R> Observable<ListChange<R>> fromObservableListDistinctMappings(final ObservableList<T> source, Function<T,R> mapper) {
165165

@@ -186,7 +186,7 @@ public static <T,R> Observable<ListChange<R>> fromObservableListDistinctMappings
186186
source.addListener(listener);
187187
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
188188

189-
}).subscribeOn(JavaFxScheduler.getInstance());
189+
}).subscribeOn(JavaFxScheduler.platform());
190190
}
191191

192192
private static final class DupeCounter<T> {

src/main/java/rx/javafx/sources/ObservableMapSource.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public static <K,T> Observable<ObservableMap<K,T>> fromObservableMap(final Obser
2020
MapChangeListener<K,T> listener = c -> subscriber.onNext(source);
2121
source.addListener(listener);
2222
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
23-
}).startWith(source).subscribeOn(JavaFxScheduler.getInstance());
23+
}).startWith(source).subscribeOn(JavaFxScheduler.platform());
2424
}
2525

2626
public static <K,T> Observable<Entry<K,T>> fromObservableMapAdds(final ObservableMap<K,T> source) {
@@ -37,7 +37,7 @@ public static <K,T> Observable<Entry<K,T>> fromObservableMapAdds(final Observabl
3737
source.addListener(listener);
3838
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
3939

40-
}).subscribeOn(JavaFxScheduler.getInstance());
40+
}).subscribeOn(JavaFxScheduler.platform());
4141
}
4242

4343
public static <K,T> Observable<Entry<K,T>> fromObservableMapRemovals(final ObservableMap<K,T> source) {
@@ -54,7 +54,7 @@ public static <K,T> Observable<Entry<K,T>> fromObservableMapRemovals(final Obser
5454
source.addListener(listener);
5555
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
5656

57-
}).subscribeOn(JavaFxScheduler.getInstance());
57+
}).subscribeOn(JavaFxScheduler.platform());
5858
}
5959

6060
public static <K,T> Observable<MapChange<K,T>> fromObservableMapChanges(final ObservableMap<K,T> source) {
@@ -74,6 +74,6 @@ public static <K,T> Observable<MapChange<K,T>> fromObservableMapChanges(final Ob
7474
source.addListener(listener);
7575
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
7676

77-
}).subscribeOn(JavaFxScheduler.getInstance());
77+
}).subscribeOn(JavaFxScheduler.platform());
7878
}
7979
}

src/main/java/rx/javafx/sources/ObservableSetSource.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public static <T> Observable<ObservableSet<T>> fromObservableSet(final Observabl
1616
SetChangeListener<T> listener = c -> subscriber.onNext(source);
1717
source.addListener(listener);
1818
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
19-
}).startWith(source).subscribeOn(JavaFxScheduler.getInstance());
19+
}).startWith(source).subscribeOn(JavaFxScheduler.platform());
2020
}
2121

2222
public static <T> Observable<T> fromObservableSetAdds(final ObservableSet<T> source) {
@@ -31,7 +31,7 @@ public static <T> Observable<T> fromObservableSetAdds(final ObservableSet<T> sou
3131
source.addListener(listener);
3232
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
3333

34-
}).subscribeOn(JavaFxScheduler.getInstance());
34+
}).subscribeOn(JavaFxScheduler.platform());
3535
}
3636

3737
public static <T> Observable<T> fromObservableSetRemovals(final ObservableSet<T> source) {
@@ -46,7 +46,7 @@ public static <T> Observable<T> fromObservableSetRemovals(final ObservableSet<T>
4646
source.addListener(listener);
4747
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
4848

49-
}).subscribeOn(JavaFxScheduler.getInstance());
49+
}).subscribeOn(JavaFxScheduler.platform());
5050
}
5151

5252
public static <T> Observable<SetChange<T>> fromObservableSetChanges(final ObservableSet<T> source) {
@@ -64,6 +64,6 @@ public static <T> Observable<SetChange<T>> fromObservableSetChanges(final Observ
6464
source.addListener(listener);
6565
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeListener(listener)));
6666

67-
}).subscribeOn(JavaFxScheduler.getInstance());
67+
}).subscribeOn(JavaFxScheduler.platform());
6868
}
6969
}

src/main/java/rx/javafx/sources/SceneEventSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ public static <T extends Event> Observable<T> fromSceneEvents(final Scene source
3535

3636
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeEventHandler(eventType, handler)));
3737

38-
}).subscribeOn(JavaFxScheduler.getInstance());
38+
}).subscribeOn(JavaFxScheduler.platform());
3939
}
4040
}

src/main/java/rx/javafx/sources/WindowEventSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ public static <T extends WindowEvent> Observable<T> fromWindowEvents(final Windo
3737

3838
subscriber.setDisposable(JavaFxSubscriptions.unsubscribeInEventDispatchThread(() -> source.removeEventHandler(eventType, handler)));
3939

40-
}).subscribeOn(JavaFxScheduler.getInstance());
40+
}).subscribeOn(JavaFxScheduler.platform());
4141
}
4242
}

src/main/java/rx/subscriptions/JavaFxSubscriptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public static Disposable unsubscribeInEventDispatchThread(final Runnable unsubsc
4040
if (Platform.isFxApplicationThread()) {
4141
unsubscribe.run();
4242
} else {
43-
final Scheduler.Worker inner = JavaFxScheduler.getInstance().createWorker();
43+
final Scheduler.Worker inner = JavaFxScheduler.platform().createWorker();
4444
inner.schedule(() -> {
4545
unsubscribe.run();
4646
inner.dispose();

0 commit comments

Comments
 (0)