Skip to content

Commit 968678f

Browse files
committed
fully delegate LazyBindingSubscriber to BindingSubscriber
1 parent b00e15b commit 968678f

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

src/main/java/rx/subscribers/LazyBindingSubscriber.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package rx.subscribers;
1818

19-
import com.sun.javafx.binding.ExpressionHelper;
2019
import javafx.beans.InvalidationListener;
2120
import javafx.beans.binding.Binding;
2221
import javafx.beans.value.ChangeListener;
@@ -30,7 +29,6 @@ final class LazyBindingSubscriber<T> implements ObservableValue<T>, Binding<T> {
3029

3130
private final Observable<T> observable;
3231
private final BindingSubscriber<T> binding;
33-
private ExpressionHelper<T> helper;
3432
private Subscription subscription;
3533

3634
LazyBindingSubscriber(Observable<T> observable, BindingSubscriber<T> binding) {
@@ -46,12 +44,12 @@ public T getValue() {
4644
}
4745
@Override
4846
public boolean isValid() {
49-
return true;
47+
return binding.isValid();
5048
}
5149

5250
@Override
5351
public void invalidate() {
54-
//does nothing
52+
binding.invalidate();
5553
}
5654

5755
@Override
@@ -71,31 +69,31 @@ public void dispose() {
7169
*/
7270
@Override
7371
public void addListener(InvalidationListener listener) {
74-
helper = ExpressionHelper.addListener(helper, this, listener);
72+
binding.addListener(listener);
7573
}
7674

7775
/**
7876
* {@inheritDoc}
7977
*/
8078
@Override
8179
public void addListener(ChangeListener<? super T> listener) {
82-
helper = ExpressionHelper.addListener(helper, this, listener);
80+
binding.addListener(listener);
8381
}
8482

8583
/**
8684
* {@inheritDoc}
8785
*/
8886
@Override
8987
public void removeListener(InvalidationListener listener) {
90-
helper = ExpressionHelper.removeListener(helper, listener);
88+
binding.removeListener(listener);
9189
}
9290

9391
/**
9492
* {@inheritDoc}
9593
*/
9694
@Override
9795
public void removeListener(ChangeListener<? super T> listener) {
98-
helper = ExpressionHelper.removeListener(helper, listener);
96+
binding.removeListener(listener);
9997
}
10098

10199
/**
@@ -106,6 +104,6 @@ public void removeListener(ChangeListener<? super T> listener) {
106104
* the following call to fireValueChangedEvent.
107105
*/
108106
protected void fireValueChangedEvent() {
109-
ExpressionHelper.fireValueChangedEvent(helper);
107+
binding.fireValueChangedEvent();
110108
}
111109
}

0 commit comments

Comments
 (0)