Skip to content

Commit a691c1e

Browse files
committed
Remove test database connection check
It doesn't work well with multiple databases configured
1 parent 289c594 commit a691c1e

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

django_tasks/backends/base.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from asgiref.sync import sync_to_async
66
from django.core.checks import messages
77
from django.db import connections
8-
from django.test.testcases import _DatabaseFailure
98
from django.utils import timezone
109
from typing_extensions import ParamSpec
1110

@@ -49,11 +48,6 @@ def _get_enqueue_on_commit_for_task(self, task: Task) -> bool:
4948
if not connections.settings:
5049
return False
5150

52-
# If connections are disabled during tests, there's nothing to commit to
53-
for conn in connections.all():
54-
if isinstance(conn.connect, _DatabaseFailure):
55-
return False
56-
5751
if task.enqueue_on_commit is not None:
5852
return task.enqueue_on_commit
5953

tests/tests/test_dummy_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def test_get_result_from_different_request(self) -> None:
132132
)
133133

134134
def test_enqueue_on_commit(self) -> None:
135-
self.assertFalse(
135+
self.assertTrue(
136136
default_task_backend._get_enqueue_on_commit_for_task(
137137
test_tasks.enqueue_on_commit_task
138138
)

tests/tests/test_immediate_backend.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def test_get_result_from_different_request(self) -> None:
198198
response = self.client.get(reverse("result", args=[result_id]))
199199

200200
def test_enqueue_on_commit(self) -> None:
201-
self.assertFalse(
201+
self.assertTrue(
202202
default_task_backend._get_enqueue_on_commit_for_task(
203203
test_tasks.enqueue_on_commit_task
204204
)

0 commit comments

Comments
 (0)