Commit to GH from JS

[DominiqueMakowski]

let's open an issue to track my attempts ^^ thanks a ton @penguimelia for having looked into that 🙌 ☺️

[DominiqueMakowski]

When I add <script type="module" src="experiment.js"></script> locally (i.e. when I open the html in my browser) I get the following

Access to script at 'file:///D:/Dropbox/RealityBendingLab/TemplateOnlineExperiment/experiment.js' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, chrome-untrusted, https.
experiment.js:1 Failed to load resource: net::ERR_FAILED

[DominiqueMakowski]

Note that this is me with JS:

[penguimelia]

yeah, i mentioned to zen that this method will require setting up a local web server. are you using VS Code? if you are, there’s a local server extension which is super easy to use. otherwise you can google “local web server setup” for something you can do on your machine too. basically bc the site is running static on your machine, with no “web” server infrastructure, for security reasons chrome prevents the local app from accessing the web and vice versa (that’s probably a shitty explanation lmao u can google CORS policy for a proper description 😂) am out rn so i’m just replying on my phone — can def look at the Issues later!!!

…

On Thu, 11 Feb 2021 at 08:54, Dominique Makowski ***@***.***> wrote: When I add <script type="module" src="experiment.js"></script> locally (i.e. when I open the html in my browser) I get the following Access to script at 'file:///D:/Dropbox/RealityBendingLab/TemplateOnlineExperiment/experiment.js' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, chrome, chrome-extension, chrome-untrusted, https.experiment.js:1 Failed to load resource: net::ERR_FAILED — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADVCYNN3KQOAK6XIYIUFGYLS6MTF5ANCNFSM4XN6RSQQ> .

[DominiqueMakowski]

basically bc the site is running static on your machine, with no “web”
server infrastructure, for security reasons chrome prevents the local app
from accessing the web and vice versa

That makes sense! I am using vscode, I'll give it a look thanks

It seems like importing the script as a module enforces the need to declare all variables is that possible? Previously the script worked but after that it errored saying that some variables were not explicitly declared

am out rn so i’m just replying on my phone — can def look at the Issues later!!!

no worries it's CNY afterall ☺️

[DominiqueMakowski]

It seems like importing the script as a module enforces the need to declare all variables is that possible? Previously the script worked but after that it errored saying that some variables were not explicitly declared

Oh yea, I didn't notice you did that in your fork as well (I'm trying to redo and understand step by step :)

[DominiqueMakowski]

I have

Failed to load resource: the server responded with a status of 401 ()
request.js:65 Uncaught (in promise) HttpError: Bad credentials
    at https://cdn.skypack.dev/-/@octokit/request@v5.4.14-2bZGuWjihBc50hc0wwRm/dist=es2020,mode=imports/optimized/@octokit/request.js:65:23

I suspect it could be the Oauth token. Here's what I did to get it, I'm not sure it's the right way:

• Went to my (personal) GH profile and to Settings
• Went to "Developper setttings" tab then to OAuth apps
• Created a new OAuth app (named jsPsychTemplate), then generated a new "Clien secret" and copy pasted the string of characters

[penguimelia]

yes that’s the right steps!! sorry was at f45. you also need to change the name of the git repo owner etc as well! ah you didn’t need to create a new oauth app, generating a new personal access token would have worked. if the oauth app doesn’t work, then try using the personal access token instead! also this won’t be allowed to live as plaintext in the repo as git will invalidate that token, so we have to look into using the repo’s environment secrets as well

…

On Thu, 11 Feb 2021 at 10:15, Dominique Makowski ***@***.***> wrote: I have Failed to load resource: the server responded with a status of 401 ()request.js:65 Uncaught (in promise) HttpError: Bad credentials at ***@***.******@***.******@***.***/request.js:65:23 I suspect it could be the Oauth token. Here's what I did to get it, I'm not sure it's the right way: - Went to my (personal) GH profile and to Settings - Went to "Developper setttings" tab then to OAuth apps - Created a new OAuth app (named jsPsychTemplate), then generated a new "Clien secret" and copy pasted the string of characters — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADVCYNJSAZCDX6P7FEO3IKLS6M4UFANCNFSM4XN6RSQQ> .

[DominiqueMakowski]

if the oauth app doesn’t work, then try using the personal access token instead!

Yeah it doesn't, I'm not sure what I did wrongly 😕

I was the charcter string circled in red that I pasted here

TemplateOnlineExperiment/experiment.js

Line 7 in cd7dd60

const octokit = new Octokit({ auth: "b4b7fbf3c2d8b7688060e1c871f7121a74d90e11" })

also this won’t be allowed to live as plaintext in the repo as git will invalidate that token, so we have to look into using the repo’s environment secrets as well

I have no idea what it means, but I believe you 😅

[penguimelia]

i think oauth apps are used to connect other apps to your application, so maybe it doesn't work like that? try doing the personal access token one instead!

I have no idea what it means, but I believe you 😅

basically just pasting your personal access token in a repo like this is dangerous becauswe people can just come in and take it and mess up your stuff, so we have to secretly save it in the repository settings in a way that only github can see, if that makes more sense?

[penguimelia]

if it'll help, i can set up a zoom pairing session and we can go through that together!! might have to be tomorrow though

[DominiqueMakowski]

So I created a personal token access, and then I created an org secret (so that it can be reused in other future repos from the org?):

with its value, but not sure now where to add that secret inside the code?

i can set up a zoom pairing session and we can go through that together!! might have to be tomorrow though

Sure! whenever you prefer, I'm quite free since @zen-juen bo'joed me from CNY