Model runner fixes (#107)

itamarhaber · lantiga · commit 1fbb4eb49b35 · 2019-04-05T01:25:05.000-07:00
As coded during RedisConf19

Signed-off-by: Itamar Haber &lt;itamar@redislabs.com&gt;
diff --git a/src/model.c b/src/model.c
@@ -218,23 +218,23 @@ RAI_ModelRunCtx* RAI_ModelRunCtxCreate(RAI_Model* model) {
   return mctx;
 }
 
-static int Model_RunCtxAddParam(RAI_ModelRunCtx* mctx, RAI_ModelCtxParam* paramArr,
+static int Model_RunCtxAddParam(RAI_ModelRunCtx* mctx, RAI_ModelCtxParam** paramArr,
                                 const char* name, RAI_Tensor* tensor) {
 
   RAI_ModelCtxParam param = {
       .name = name,
       .tensor = tensor ? RAI_TensorGetShallowCopy(tensor): NULL,
   };
-  paramArr = array_append(paramArr, param);
+  *paramArr = array_append(*paramArr, param);
   return 1;
 }
 
 int RAI_ModelRunCtxAddInput(RAI_ModelRunCtx* mctx, const char* inputName, RAI_Tensor* inputTensor) {
-  return Model_RunCtxAddParam(mctx, mctx->inputs, inputName, inputTensor);
+  return Model_RunCtxAddParam(mctx, &mctx->inputs, inputName, inputTensor);
 }
 
 int RAI_ModelRunCtxAddOutput(RAI_ModelRunCtx* mctx, const char* outputName) {
-  return Model_RunCtxAddParam(mctx, mctx->outputs, outputName, NULL);
+  return Model_RunCtxAddParam(mctx, &mctx->outputs, outputName, NULL);
 }
 
 size_t RAI_ModelRunCtxNumOutputs(RAI_ModelRunCtx* mctx) {

Original file line number	Diff line number	Diff line change
`@@ -218,23 +218,23 @@ RAI_ModelRunCtx* RAI_ModelRunCtxCreate(RAI_Model* model) {`
`218`	`218`	`return mctx;`
`219`	`219`	`}`
`220`	`220`
`221`		`-static int Model_RunCtxAddParam(RAI_ModelRunCtx* mctx, RAI_ModelCtxParam* paramArr,`
	`221`	`+static int Model_RunCtxAddParam(RAI_ModelRunCtx* mctx, RAI_ModelCtxParam** paramArr,`
`222`	`222`	`const char* name, RAI_Tensor* tensor) {`
`223`	`223`
`224`	`224`	`RAI_ModelCtxParam param = {`
`225`	`225`	`.name = name,`
`226`	`226`	`.tensor = tensor ? RAI_TensorGetShallowCopy(tensor): NULL,`
`227`	`227`	`};`
`228`		`- paramArr = array_append(paramArr, param);`
	`228`	`+ paramArr = array_append(paramArr, param);`
`229`	`229`	`return 1;`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	`int RAI_ModelRunCtxAddInput(RAI_ModelRunCtx* mctx, const char* inputName, RAI_Tensor* inputTensor) {`
`233`		`- return Model_RunCtxAddParam(mctx, mctx->inputs, inputName, inputTensor);`
	`233`	`+ return Model_RunCtxAddParam(mctx, &mctx->inputs, inputName, inputTensor);`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`int RAI_ModelRunCtxAddOutput(RAI_ModelRunCtx* mctx, const char* outputName) {`
`237`		`- return Model_RunCtxAddParam(mctx, mctx->outputs, outputName, NULL);`
	`237`	`+ return Model_RunCtxAddParam(mctx, &mctx->outputs, outputName, NULL);`
`238`	`238`	`}`
`239`	`239`
`240`	`240`	`size_t RAI_ModelRunCtxNumOutputs(RAI_ModelRunCtx* mctx) {`