Skip to content

( nor urgent ) lines of code never called in STEDC #1143

@langou

Description

@langou

In DSTEDC, it seems that these lines of code are never called and so can safely been removed:

lapack/SRC/dstedc.f

Lines 439 to 444 in efbd2fd

IF( ICOMPZ.EQ.0 ) THEN
*
* Use Quick Sort
*
CALL DLASRT( 'I', N, D, INFO )
*

Lines 439 to 444 are never called since, at lines 306, IF( ICOMPZ.EQ.0 ) THEN we call STERF and GOTO 50

lapack/SRC/dstedc.f

Lines 306 to 311 in efbd2fd

* If COMPZ = 'N', use DSTERF to compute the eigenvalues.
*
IF( ICOMPZ.EQ.0 ) THEN
CALL DSTERF( N, D, E, INFO )
GO TO 50
END IF

and, after 50 CONTINUE, STEDC ends

lapack/SRC/dstedc.f

Lines 468 to 476 in efbd2fd

50 CONTINUE
WORK( 1 ) = LWMIN
IWORK( 1 ) = LIWMIN
*
RETURN
*
* End of DSTEDC
*
END

It is not possible that ICOMPZ is 0 in lines 439 to 444, so the lines are never executed.

Thanks to @BrianDang03 for pointing this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions