-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
Description
Federation HTTP requests in FederationRequestService.makeSignedRequest() currently lack timeout handling, which can cause requests to hang indefinitely on network issues.
Context
The @hs/core fetch implementation doesn't include built-in timeout support. This was identified during review of PR #191.
Proposed Solution
Add configurable timeout support using one of these approaches:
- Use AbortController with setTimeout to cancel long-running requests
- Extend
@hs/corefetch to accepttimeoutMsorsignalparameters - Add a configurable timeout (e.g.,
FEDERATION_REQUEST_TIMEOUT_MS) with reasonable default (~15s)
Files Affected
packages/federation-sdk/src/services/federation-request.service.ts- Potentially
@hs/corefetch implementation
References
- Original PR: chore: use crypto package everywhere #191
- Comment: chore: use crypto package everywhere #191 (comment)
/cc @debdutdeb
Metadata
Metadata
Assignees
Labels
No labels