-
-
Notifications
You must be signed in to change notification settings - Fork 29
[Bug] Left and right keys to skip pages not working when zoom is set to "Fit page" #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
After submitting the issue and doing some more tests, I realised it might be an Obsidian bug? Obsidian's own PDF viewer doesn't allow to skip pages if the user sets a custom zoom level (Even when setting it to the same zoom level as Fit width/height). But the plugin's fit page does the same thing as Fit width/height, just taking the minimum value? So as a user expect it to behave the same? Anyway, I'm pretty sure its an Obsidian bug, might submit it to the forums when I'm free (or someone else can do it too, if they want). Just leaving the issue up to let you and other users know about it. Feel free to close the issue. Thanks for making and maintaining the plugin, ありがとうございます! |
As you have noticed, this is how Obsidian's bulit-in PDF viewer works, and it's actually by design.
❤ |
Ah I didn't notice that option, will use it in the future. Thanks for the quick reply! |
Just a thought: For future users, would you consider adding an option to override Obsidian’s default behavior? I imagine you could implement it pretty easily. Looking at your code, it seems like just adding the "ArrowDown" and "ArrowUp" keybindings in this section? Of course, you are much more familiar with the codebase the docs than I am. Just thought I’d share the idea in case it’s helpful. I also haven't looked at Obsidian's code or build and tested what I suggested so I'm not even sure if it'll work. |
Yeah, but you wouldn't want that because you will not be able to use the arrow keys for scrolling. |
Oh I meant ArrowLeft and ArrowRight. Sorry was mistaken. |
Steps to reproduce
Did in sandbox vault with only PDF++ installed
Expected behavior
Expect to skip pages, like how it works in "Fit width"/"Fit height".
Actual behavior
Nothing happens
Screen recordings or screenshots
Wrote my actions on the side panel as I can't show my key presses
Debug info
Obsidian debug info
PDF++ debug info
Error messages (optional)
Happened when I ran the "Reload app without saving" command. Don't think it affected the bug

The text was updated successfully, but these errors were encountered: