Function readWholeBuffer causes issues on SSL connections

[GoogleCodeExporter]

Hi,

Above all, i know that secure SSL support are not fully tested.

When using SSL, readWholeBuffer doesn't work very well (after some research).
If fact, it seems that $metadata['unread_bytes'] causes the error. And in the 
PHP doc, i can read : "Note: You shouldn't use this value in a script."

If you print the buffer (with SSL activated) it is always "G" (The "G" of "GET 
....")

So i tried this :

public static function readWholeBuffer($resource){
        $buffer = '';
        $buffsize = 8192;

        $metadata['unread_bytes'] = 0;

        /*do{
            if(feof($resource))
            {
                return false;
            }

            $result = fread($resource, $buffsize);
            if($result === false || feof($resource))
            {
                    return false;
            }
            $buffer .= $result;

            $metadata = stream_get_meta_data($resource);

            $buffsize = min($buffsize, $metadata['unread_bytes']);

        } while($metadata['unread_bytes'] > 0);*/

        do {
            $result = fread($resource, $buffsize);

            if( $result === false ) {
                return false;
            }

            $buffer .= $result;

            $metadata = stream_get_meta_data($resource);
        } while( !feof($resource) );

        return $buffer;
}

It is working with SSL but not without SSL (it's blocking on the 'fread' 
instruction). Any Ideas ?

I'm using Google Chrome 17 ( Sec-WebSocket-Version: 13 ) and php 5.2.9 ( i've 
changed websocket.server.php a little to make it work with 5.2.9 )

Regards,

Vince

Original issue reported on code.google.com by and1hots...@gmail.com on 1 Mar 2012 at 9:13

[GoogleCodeExporter]

Nope, my code doesn't work with SSL either.
After read all the headers (but not only the "G"), it's also blocking on 
fread...

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 9:28

[GoogleCodeExporter]

This seems to work.

First a set the stream as non-blocking,
I read the socket until I am no longer receiving data ( i.e. fread() return '', 
i.e. strlen(fread()) is nul)
After reading, i set the stream as blocking (as before the read) and return the 
buffer

public static function readWholeBuffer($resource){
    $buffer = '';
    $buffsize = 8192;

    $metadata['unread_bytes'] = 0;

    stream_set_blocking($resource, 0);

    while( !feof($resource) ) {

        $result = fread($resource, $buffsize);

        if( $result === false ) {
                return false;
        }

        if( strlen($result) == 0 ) {
                break;
        }

        $buffer .= $result;

    }

    stream_set_blocking($resource, 1);

    return $buffer;
}

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 11:13

[GoogleCodeExporter]

$metadata array is not used anymore.

public static function readWholeBuffer($resource){
    $buffer = '';
    $buffsize = 8192;

    stream_set_blocking($resource, 0);

    while( !feof($resource) ) {

        $result = fread($resource, $buffsize);

        if( $result === false ) {
                return false;
        }

        if( strlen($result) == 0 ) {
                break;
        }

        $buffer .= $result;

    }

    stream_set_blocking($resource, 1);

    return $buffer;
}

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 11:15

[GoogleCodeExporter]

Thanks for your adjustments. I will test them out on my server. When the server 
is still stable I will commit your changes.

Again, thanks a lot for your help!

Chris

Original comment by ch...@devristo.com on 1 Mar 2012 at 3:49

[GoogleCodeExporter]

You're welcome. You've made a nice work too

I already try it and I'll post if I find bugs;-)

Vincent

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 4:01

[GoogleCodeExporter]

Thanks, I just had a minor hickup. Not sure if it has to do with your changes. 
After a restart it works fine.

To be sure I will wait a day or two before committing the changes :)

BTW: Did you manage to get SSL to work?

Original comment by ch...@devristo.com on 1 Mar 2012 at 4:06

[GoogleCodeExporter]

Hmmm, again a hickup. Weird.

Original comment by ch...@devristo.com on 1 Mar 2012 at 4:07

[GoogleCodeExporter]

This part seems incorrect due to the nature of non blocking sockets.

[[if( strlen($result) == 0 ) {
break;
}]]

It will break too soon if there is still data in transit.

Original comment by ch...@devristo.com on 1 Mar 2012 at 4:13

[GoogleCodeExporter]

I see what you mean. But I didn't had this problem today. Maybe it will appear 
with a (very) slow connection ?

Yes i'm using it with SSL with success (for one global control socket and 
others to upload files (so with a lot of send()). It works great.

Is there an other way to know if all data sent has been received ?

Regards

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 4:52

[GoogleCodeExporter]

I am not sure. I have had similar problems before, after using the meta data 
(which I know is not correct) it was fixed. PHPWS was my first socket related 
project, so I am quite sure I missed the obvious, correct, solution.

Original comment by ch...@devristo.com on 1 Mar 2012 at 5:25

[GoogleCodeExporter]

In this link ( http://www.php.net/manual/fr/function.stream-get-contents.php ) 
i can read this :

"clarck dot smith at gmail dot com 17-Dec-2011 07:12 :

In that case when stream_get_contents/fread/fgets or other stream reading 
functions block indefinitely your script because they don't reached the limit 
of bytes to read use the socket_get_meta_data function to figure out the number 
of the bytes to read. It returns an array that contains a key named 
'unread_bytes' and then pass that number to your favourite stream reading 
functions second parameter to read from the stream.

Maybe a good workaround to use the stream_select function, and set the socket 
to non-blocking mode with the use of stream_set_blocking($stream, 0). In this 
case the socket reading functions work properly.

Cheers, Ervin"

It is the case with my function because you are already using stream_select.

Original comment by and1hots...@gmail.com on 1 Mar 2012 at 6:06

[GoogleCodeExporter]

Yeah I use socket select, but without blocking mode. Your solution, unblock the 
socket temporarily, should be fine. However I dont have time right now to fix 
the bug that it causes.

Original comment by ch...@devristo.com on 2 Mar 2012 at 5:40