From f2cc2f0e368e71eb7795cb30665e59f34873ad3c Mon Sep 17 00:00:00 2001 From: unknown <176206@bme.hu> Date: Wed, 15 Oct 2025 16:52:27 +0200 Subject: [PATCH 1/3] TorpedoStore_Exception_fix --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index 76a3cea..89ab21a 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -30,7 +30,7 @@ public TorpedoStore(int numberOfTorpedos){ public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ - new IllegalArgumentException("numberOfTorpedos"); + throw new IllegalArgumentException("numberOfTorpedos"); } boolean success = false; From 883e61b7bd54156c03ae5fe0b82036e5ac1f75a1 Mon Sep 17 00:00:00 2001 From: unknown <176206@bme.hu> Date: Wed, 15 Oct 2025 16:53:04 +0200 Subject: [PATCH 2/3] TorpedoStore_Random_Generator_fix --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index 89ab21a..7cb12c9 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -28,6 +28,8 @@ public TorpedoStore(int numberOfTorpedos){ } } + private Random generator = new Random(); + public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ throw new IllegalArgumentException("numberOfTorpedos"); @@ -36,7 +38,6 @@ public boolean fire(int numberOfTorpedos){ boolean success = false; // simulate random overheating of the launcher bay which prevents firing - Random generator = new Random(); double r = generator.nextDouble(); if (r >= FAILURE_RATE) { From 1a0f798e7889766acb82cff2304739967ccc20c3 Mon Sep 17 00:00:00 2001 From: unknown <176206@bme.hu> Date: Wed, 15 Oct 2025 16:53:50 +0200 Subject: [PATCH 3/3] TorpedoStore_Operator_fix --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index 7cb12c9..215e7d7 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -42,7 +42,7 @@ public boolean fire(int numberOfTorpedos){ if (r >= FAILURE_RATE) { // successful firing - this.torpedoCount =- numberOfTorpedos; + this.torpedoCount -= numberOfTorpedos; success = true; } else { // simulated failure