Skip to content

Commit 3b193ff

Browse files
committed
Mem per command was never used - fixed
1 parent 8446e5e commit 3b193ff

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

scripts/smart-dispatch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def main():
161161

162162
command_params = {'nb_cores_per_command': args.coresPerCommand,
163163
'nb_gpus_per_command': args.gpusPerCommand,
164-
'mem_per_command': None # args.memPerCommand
164+
'mem_per_command': args.memPerCommand
165165
}
166166

167167
prolog = []

smartdispatch/job_generator.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,6 @@ def _generate_base_pbs(self):
8383
# Limit number of running commands by the amount of available memory on the node.
8484
if self.mem_per_command is not None:
8585
nb_commands_per_node = min(nb_commands_per_node, self.queue.mem_per_node // self.mem_per_command)
86-
mem_per_command = self.mem_per_command
87-
else:
88-
mem_per_command = self.queue.mem_per_node // nb_commands_per_node
8986

9087
pbs_files = []
9188
# Distribute equally the jobs among the PBS files and generate those files
@@ -101,8 +98,9 @@ def _generate_base_pbs(self):
10198
resource += ":gpus={gpus}".format(gpus=len(commands) * self.nb_gpus_per_command)
10299
pbs.add_resources(nodes=resource)
103100

104-
resource = "{mem}Gb".format(mem=len(commands) * mem_per_command)
105-
pbs.add_resources(mem=resource)
101+
if self.mem_per_command is not None:
102+
resource = "{mem}Gb".format(mem=len(commands) * self.mem_per_command)
103+
pbs.add_resources(mem=resource)
106104

107105
pbs.add_modules_to_load(*self.queue.modules)
108106
pbs.add_to_prolog(*self.prolog)

0 commit comments

Comments
 (0)