Skip to content

Commit af565a0

Browse files
committed
Mem per command was never used - fixed
1 parent 14898bd commit af565a0

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

scripts/smart-dispatch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def main():
131131

132132
command_params = {'nb_cores_per_command': args.coresPerCommand,
133133
'nb_gpus_per_command': args.gpusPerCommand,
134-
'mem_per_command': None # args.memPerCommand
134+
'mem_per_command': args.memPerCommand
135135
}
136136

137137
job_generator = job_generator_factory(queue, commands, command_params, CLUSTER_NAME, path_job)

smartdispatch/job_generator.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ def _generate_base_pbs(self):
7777
# Limit number of running commands by the amount of available memory on the node.
7878
if self.mem_per_command is not None:
7979
nb_commands_per_node = min(nb_commands_per_node, self.queue.mem_per_node // self.mem_per_command)
80-
mem_per_command = self.mem_per_command
81-
else:
82-
mem_per_command = self.queue.mem_per_node // nb_commands_per_node
8380

8481
pbs_files = []
8582
# Distribute equally the jobs among the PBS files and generate those files
@@ -95,8 +92,9 @@ def _generate_base_pbs(self):
9592
resource += ":gpus={gpus}".format(gpus=len(commands) * self.nb_gpus_per_command)
9693
pbs.add_resources(nodes=resource)
9794

98-
resource = "{mem}Gb".format(mem=len(commands) * mem_per_command)
99-
pbs.add_resources(mem=resource)
95+
if self.mem_per_command is not None:
96+
resource = "{mem}Gb".format(mem=len(commands) * self.mem_per_command)
97+
pbs.add_resources(mem=resource)
10098

10199
pbs.add_modules_to_load(*self.queue.modules)
102100
pbs.add_commands(*commands)

0 commit comments

Comments
 (0)