Addressed @ASalvail's comments

Author: MarcCote

smartdispatch/argument_template.py

@@ -35,7 +35,7 @@ def unfold(self, match):
         start = int(groups[0])
         end = int(groups[1])
         step = 1 if groups[2] is None else int(groups[2])
-        return list(map(str, range(start, end, step)))
+        return [str(i) for i in range(start, end, step)]
 
 
 argument_templates = build_argument_templates_dictionnary()

smartdispatch/smartdispatch.py

@@ -96,7 +96,7 @@ def unfold_command(command):
         pos = match.end()
 
     arguments.append([text[pos:]])  # Add remaining unfolded arguments
-    arguments = [list(map(utils.decode_escaped_characters, argvalues)) for argvalues in arguments]
+    arguments = [[utils.decode_escaped_characters(v) for v in argvalues] for argvalues in arguments]
     return ["".join(argvalues) for argvalues in itertools.product(*arguments)]
 
 

smartdispatch/utils.py

@@ -60,11 +60,13 @@ def slugify(value):
     ---------
     https://github.com/django/django/blob/1.7c3/django/utils/text.py#L436
     """
+    # Convert `value` to Unicode so we can slugify it using the unicodedata module.
     try:
         value = unicode(value, "UTF-8")
     except NameError:
-        pass  # In Python 3 all strings are already unicode.
+        pass  # In Python 3, all strings are already stored as Unicode.
 
+    # Replace all compatibility characters with their equivalents.
     value = unicodedata.normalize('NFKD', value).encode('ascii', 'ignore').decode('ascii')
     value = re.sub('[^\w\s-]', '', value).strip().lower()
     return str(re.sub('[-\s]+', '_', value))

tests/test_smart_worker.py

@@ -22,7 +22,7 @@ def setUp(self):
         self.command_manager = CommandManager(os.path.join(self._commands_dir, "commands.txt"))
         self.command_manager.set_commands_to_run(self.commands)
 
-        self.commands_uid = list(map(utils.generate_uid_from_string, self.commands))
+        self.commands_uid = [utils.generate_uid_from_string(c) for c in self.commands]
 
     def tearDown(self):
         shutil.rmtree(self._commands_dir)