Skip to content

Fornax_2019 initial spectra unit is different from other models #403

@Sheshuk

Description

@Sheshuk

Trying to make notebooks work in #402 I have the following problem.

In Fornax_2019.get_initial_spectra we have:

initialspectra[flavor] = _dLdE * self.fluxunit

where the flux_unit is defined in the c-tor:
self.fluxunit = 1e50 * u.erg/(u.s*u.MeV)

so the initialspectra entries are [1/s].

In all the other models we have initialspectra units ~ [1/(MeV s)].

As we're passing everithing to flux.Container, it checks the units compatibility and showed this issue.

Maybe it can be solved by a simple unit conversion? But I'm not very familiar with the internals of Fornax models, so I suggest to discuss this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    SupernovaModelImplementing/correcting supernova modelbugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions