Scaffolded workflows use deprecated 'app-id' input for create-github-app-token@v3

[genesis-dev-bot]

What went wrong

The scaffolded genesis workflows use app-id: as the input to actions/create-github-app-token@v3. This input was deprecated in the action's v3 release in favour of client-id:. Every single workflow run across all 4 genesis workflows produces this deprecation warning:

Input 'app-id' has been deprecated with message: Use 'client-id' instead.

Observed in: Sayfan-AI/ronny-learns-ai — all 4 genesis workflow files affected.

Proposed fix

In all scaffolded workflow templates, rename the app-id: input key to client-id::

# Before
- uses: actions/create-github-app-token@v3
  id: app-token
  with:
    app-id: ${{ secrets.GENESIS_APP_ID }}

# After
- uses: actions/create-github-app-token@v3
  id: app-token
  with:
    client-id: ${{ secrets.GENESIS_APP_ID }}

The secret name (GENESIS_APP_ID) and the secret value remain unchanged — only the YAML input key changes. Existing projects can continue using the GENESIS_APP_ID secret name.

Affected scaffolded templates: genesis-orchestrator.yml, genesis-events.yml, genesis-evolver.yml, genesis-push-trigger.yml.