Skip to content

Support whitespaces in definitions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support whitespaces in definitions #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d060688
Add test
zverok Dec 14, 2024
2bda7f2
More resilient regexp for column names in SchemaDumper
zverok Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/schema_plus/core/active_record/schema_dumper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def tables(_)
%r{
^
t\.(?<type>\S+) \s*
[:'"](?<name>[^"\s]+)[,"]? \s*
(:(?<name>[a-z_]+)|"(?<name>[^"]+)"|'(?<name>[^']+)') \s*
,? \s*
(?<options>.*)
$
Expand Down
8 changes: 8 additions & 0 deletions spec/dumper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ def after(env)
Then { expect(dump use_middleware: false).to match(/\\"substring\\"\(\(random/) }
end

context "column with a whitespace", postgresql: :only do
before(:each) do
migration.execute %Q{ALTER TABLE "things" ADD "whitespaced column" integer}
end

Then { expect(dump use_middleware: false).to include('t.integer "whitespaced column"') }
end

context TestDumper::Middleware::Dumper::Initial do
Then { expect(dump).to match(/Schema([\[\].0-9]+)?[.]define.*do\s+#{middleware}/) }
end
Expand Down
Loading