Skip to content

Commit 97b2d65

Browse files
reneSchmHenrZu
andauthored
1361 python CI: Build wheels without SDist (#1360)
- build wheels directly from the working tree instead. Skip SDIst for now - In latest version, the default case was set using the SDist. Therefore, our CI was failing in the last days Co-authored-by: HenrZu <69154294+HenrZu@users.noreply.github.com>
1 parent f59a074 commit 97b2d65

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/actions/build-py/action.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ runs:
99
steps:
1010
- name: Install dependencies
1111
shell: bash
12-
run: yum install ninja-build -qy
12+
run: yum install ninja-build cmake git -qy
1313
- name: Make artifact dir
1414
shell: bash
1515
run: |
@@ -19,8 +19,10 @@ runs:
1919
shell: bash
2020
run: |
2121
cd pycode/memilio-${{ inputs.package }}/
22-
/opt/python/cp38-cp38/bin/python setup.py bdist_wheel
23-
/opt/python/cp311-cp311/bin/python setup.py bdist_wheel
22+
/opt/python/cp38-cp38/bin/python -m pip install scikit-build
23+
/opt/python/cp38-cp38/bin/python -m build --no-isolation --wheel
24+
/opt/python/cp311-cp311/bin/python -m pip install scikit-build
25+
/opt/python/cp311-cp311/bin/python -m build --no-isolation --wheel
2426
# Exclude memilio-generation, because its a pure python package, cmake is only used in the build process to retrieve data from cpp
2527
if [[ -f "CMakeLists.txt" ]] && [ "${{ inputs.package }}" != "generation" ]; then
2628
# includes native dependencies in the wheel
@@ -35,4 +37,3 @@ runs:
3537
with:
3638
name: python-wheels-${{ inputs.package }}
3739
path: pycode/wheelhouse
38-

pycode/memilio-generation/setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
description='Part of MEmilio project, automatic generation of model specific python bindings.',
2626
packages=find_packages(
2727
where=os.path.dirname(os.path.abspath(__file__))),
28-
setup_requires=['cmake'],
2928
install_requires=['libclang==18.1.1',
3029
'dataclasses', 'dataclasses_json', 'graphviz', 'importlib-resources>=1.1.0; python_version < \'3.9\''],
3130
extras_require={'dev': []},

pycode/memilio-simulation/setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
url='https://github.com/SciCompMod/memilio',
2222
description='Part of MEmilio project, python bindings to the C++ libraries that contain the models and simulations.',
2323
packages=find_packages(where=os.path.dirname(os.path.abspath(__file__))),
24-
setup_requires=['cmake'],
2524
# need shared libs so there is one shared log level
2625
cmake_args=['-DMEMILIO_BUILD_SHARED_LIBS:BOOL=ON'],
2726
install_requires=[

0 commit comments

Comments
 (0)