refactor: rework the package to be Reactant first#60
Merged
Conversation
Member
Author
|
haven't fixed all issues. time for another c++ debugging session 😢 |
Member
Author
|
now we wait again for 3 hrs JuliaPackaging/Yggdrasil#11351 |
avik-pal
force-pushed
the
ap/reactant_native
branch
from
e4e3506 to
ac919b5
Compare
| ps_ra, st_ra = reactant_device(ps, st) | ||
| x_ra, y_ra = reactant_device(x, y) | ||
| # ps_ra, st_ra = (ps, st) |> reactant_device() | ||
| # x_ra, y_ra = (x, y) |> reactant_device() |
| ps_ra, st_ra = reactant_device(ps, st) | ||
| x_ra, y_ra = reactant_device(x, y) | ||
| # ps_ra, st_ra = (ps, st) |> reactant_device() | ||
| # x_ra, y_ra = (x, y) |> reactant_device() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping all the manual shenanigans with permuted because our old codegen sucked. moving to reactant we dont need these manual optimizations, instead it can be handled with passes on the mlir level
TODOs
rfftandirfftEnzymeAD/Reactant.jl#246cannot be converted to LLVM IR: missingwe have a workaroundLLVMTranslationDialectInterfaceregistration for dialect for op: func.func EnzymeAD/Reactant.jl#1365