remove unused toggles

Author: jClugstor

lib/NonlinearSolveBase/src/verbosity.jl

@@ -7,27 +7,15 @@ diagnostic messages, warnings, and errors during nonlinear system solution.
 # Fields
 
 ## Error Control Group
-- `immutable_u0`: Messages when u0 is immutable
-- `non_enclosing_interval`: Messages when interval doesn't enclose root
-- `non_forward_mode`: Messages when forward mode AD is not used
-- `fd_ad_caution`: Messages about finite differencing cautions
-- `ad_backend_incompatible`: Messages when AD backend is incompatible
+- `non_enclosing_interval`: Messages when interval doesn't enclose root (bracketing methods)
 - `alias_u0_immutable`: Messages when aliasing u0 with immutable array
 - `linsolve_failed_noncurrent`: Messages when linear solve fails on non-current iteration
-- `jacobian_free`: Messages about jacobian-free methods
 - `termination_condition`: Messages about termination conditions
 
-## Performance Group
-- `colorvec_non_sparse`: Messages when color vector is used with non-sparse matrix
-- `colorvec_no_prototype`: Messages when color vector has no prototype
-- `sparsity_using_jac_prototype`: Messages when using jacobian prototype for sparsity
-- `sparse_matrixcolorings_not_loaded`: Messages when SparseMatrixColorings not loaded
-
 ## Numerical Group
-- `threshold_state`: Messages about threshold state
-- `pinv_undefined`: Messages when pseudoinverse is undefined
+- `threshold_state`: Messages about threshold state in low-rank methods
 
-## Linear Solver
+## Linear Solver Group
 - `linear_verbosity`: Verbosity configuration for linear solvers
 
 # Constructors
@@ -59,51 +47,36 @@ verbose = NonlinearVerbosity(
 
 # Set individual fields
 verbose = NonlinearVerbosity(
-    immutable_u0 = SciMLLogging.WarnLevel(),
+    alias_u0_immutable = SciMLLogging.WarnLevel(),
     threshold_state = SciMLLogging.InfoLevel()
 )
 
 # Mix group and individual settings
 verbose = NonlinearVerbosity(
     numerical = SciMLLogging.InfoLevel(),  # Set all numerical to InfoLevel
-    pinv_undefined = SciMLLogging.ErrorLevel()  # Override specific field
+    threshold_state = SciMLLogging.ErrorLevel()  # Override specific field
 )
 ```
 """
 @concrete struct NonlinearVerbosity <: AbstractVerbositySpecifier
     # Linear verbosity
     linear_verbosity
     # Error control
-    immutable_u0
     non_enclosing_interval
-    non_forward_mode
-    fd_ad_caution
-    ad_backend_incompatible
     alias_u0_immutable
     linsolve_failed_noncurrent
-    jacobian_free
     termination_condition
-    # Performance
-    colorvec_non_sparse
-    colorvec_no_prototype
-    sparsity_using_jac_prototype
-    sparse_matrixcolorings_not_loaded
     # Numerical
     threshold_state
-    pinv_undefined
 end
 
 # Group classifications
 const error_control_options = (
-    :immutable_u0, :non_enclosing_interval, :non_forward_mode, :fd_ad_caution,
-    :ad_backend_incompatible, :alias_u0_immutable, :linsolve_failed_noncurrent,
-    :jacobian_free, :termination_condition
-)
-const performance_options = (
-    :colorvec_non_sparse, :colorvec_no_prototype, :sparsity_using_jac_prototype,
-    :sparse_matrixcolorings_not_loaded
+    :non_enclosing_interval, :alias_u0_immutable, :linsolve_failed_noncurrent,
+    :termination_condition
 )
-const numerical_options = (:threshold_state, :pinv_undefined)
+const performance_options = ()
+const numerical_options = (:threshold_state,)
 
 function option_group(option::Symbol)
     if option in error_control_options
@@ -121,13 +94,13 @@ end
 function group_options(verbosity::NonlinearVerbosity, group::Symbol)
     if group === :error_control
         return NamedTuple{error_control_options}(getproperty(verbosity, opt)
-        for opt in error_control_options)
+                                                 for opt in error_control_options)
     elseif group === :performance
         return NamedTuple{performance_options}(getproperty(verbosity, opt)
-        for opt in performance_options)
+                                               for opt in performance_options)
     elseif group === :numerical
         return NamedTuple{numerical_options}(getproperty(verbosity, opt)
-        for opt in numerical_options)
+                                             for opt in numerical_options)
     else
         error("Unknown group: $group")
     end
@@ -161,21 +134,11 @@ function NonlinearVerbosity(;
     # Build arguments using NamedTuple for type stability
     default_args = (
         linear_verbosity = linear_verbosity === nothing ? Minimal() : linear_verbosity,
-        immutable_u0 = WarnLevel(),
         non_enclosing_interval = WarnLevel(),
-        non_forward_mode = WarnLevel(),
-        fd_ad_caution = WarnLevel(),
-        ad_backend_incompatible = WarnLevel(),
         alias_u0_immutable = WarnLevel(),
         linsolve_failed_noncurrent = WarnLevel(),
-        jacobian_free = WarnLevel(),
         termination_condition = WarnLevel(),
-        colorvec_non_sparse = WarnLevel(),
-        colorvec_no_prototype = WarnLevel(),
-        sparsity_using_jac_prototype = WarnLevel(),
-        sparse_matrixcolorings_not_loaded = WarnLevel(),
-        threshold_state = WarnLevel(),
-        pinv_undefined = WarnLevel()
+        threshold_state = WarnLevel()
     )
 
     # Apply group-level settings
@@ -206,64 +169,34 @@ function NonlinearVerbosity(verbose::AbstractVerbosityPreset)
         # Minimal: Only fatal errors and critical warnings
         NonlinearVerbosity(
             linear_verbosity = Minimal(),
-            immutable_u0 = WarnLevel(),
             non_enclosing_interval = WarnLevel(),
-            non_forward_mode = Silent(),
-            fd_ad_caution = Silent(),
-            ad_backend_incompatible = WarnLevel(),
             alias_u0_immutable = Silent(),
             linsolve_failed_noncurrent = WarnLevel(),
-            jacobian_free = Silent(),
             termination_condition = Silent(),
-            colorvec_non_sparse = Silent(),
-            colorvec_no_prototype = Silent(),
-            sparsity_using_jac_prototype = Silent(),
-            sparse_matrixcolorings_not_loaded = Silent(),
-            threshold_state = Silent(),
-            pinv_undefined = ErrorLevel()
+            threshold_state = Silent()
         )
     elseif verbose isa Standard
         # Standard: Everything from Minimal + non-fatal warnings
         NonlinearVerbosity()
     elseif verbose isa Detailed
         # Detailed: Everything from Standard + debugging/solver behavior
         NonlinearVerbosity(
-            linear_verbosity = Minimal(),
-            immutable_u0 = WarnLevel(),
+            linear_verbosity = Detailed(),
             non_enclosing_interval = WarnLevel(),
-            non_forward_mode = InfoLevel(),
-            fd_ad_caution = WarnLevel(),
-            ad_backend_incompatible = WarnLevel(),
             alias_u0_immutable = WarnLevel(),
             linsolve_failed_noncurrent = WarnLevel(),
-            jacobian_free = InfoLevel(),
             termination_condition = WarnLevel(),
-            colorvec_non_sparse = InfoLevel(),
-            colorvec_no_prototype = InfoLevel(),
-            sparsity_using_jac_prototype = InfoLevel(),
-            sparse_matrixcolorings_not_loaded = InfoLevel(),
-            threshold_state = WarnLevel(),
-            pinv_undefined = WarnLevel()
+            threshold_state = WarnLevel()
         )
     elseif verbose isa All
         # All: Maximum verbosity - every possible logging message at InfoLevel
         NonlinearVerbosity(
-            linear_verbosity = All(),
-            immutable_u0 = WarnLevel(),
+            linear_verbosity = Detailed(),
             non_enclosing_interval = WarnLevel(),
-            non_forward_mode = InfoLevel(),
-            fd_ad_caution = WarnLevel(),
-            ad_backend_incompatible = WarnLevel(),
             alias_u0_immutable = WarnLevel(),
             linsolve_failed_noncurrent = WarnLevel(),
-            jacobian_free = InfoLevel(),
             termination_condition = WarnLevel(),
-            colorvec_non_sparse = InfoLevel(),
-            colorvec_no_prototype = InfoLevel(),
-            sparsity_using_jac_prototype = InfoLevel(),
-            sparse_matrixcolorings_not_loaded = InfoLevel(),
-            threshold_state = InfoLevel(),
-            pinv_undefined = WarnLevel()
+            threshold_state = InfoLevel()
         )
     end
 end
@@ -275,16 +208,6 @@ end
         Silent(),
         Silent(),
         Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
-        Silent(),
         Silent()
     )
 end
@@ -303,5 +226,4 @@ end
     else
         return default_val
     end
-end
-
+end

lib/NonlinearSolveSpectralMethods/src/solve.jl

@@ -188,8 +188,8 @@ function InternalAPI.step!(
         kwargs...
 )
     if recompute_jacobian !== nothing
-        @SciMLMessage("GeneralizedDFSane is a Jacobian-Free Algorithm. Ignoring \
-              `recompute_jacobian`", cache.verbose, :jacobian_free)
+        @warn "GeneralizedDFSane is a Jacobian-Free Algorithm. Ignoring \
+              `recompute_jacobian`"
     end
 
     @static_timeit cache.timer "descent" begin

test/verbosity_tests.jl

@@ -13,69 +13,60 @@
         v_standard = NonlinearVerbosity(SciMLLogging.Standard())
         v_detailed = NonlinearVerbosity(SciMLLogging.Detailed())
 
-        @test v_none.immutable_u0 isa SciMLLogging.Silent
+        @test v_none.non_enclosing_interval isa SciMLLogging.Silent
         @test v_none.threshold_state isa SciMLLogging.Silent
-        @test v_none.colorvec_non_sparse isa SciMLLogging.Silent
+        @test v_none.alias_u0_immutable isa SciMLLogging.Silent
 
-        @test v_minimal.immutable_u0 isa SciMLLogging.WarnLevel
-        @test v_minimal.colorvec_non_sparse isa SciMLLogging.Silent
-        @test v_minimal.non_forward_mode isa SciMLLogging.Silent
+        @test v_minimal.non_enclosing_interval isa SciMLLogging.WarnLevel
+        @test v_minimal.alias_u0_immutable isa SciMLLogging.Silent
+        @test v_minimal.termination_condition isa SciMLLogging.Silent
 
-        @test v_standard.immutable_u0 isa SciMLLogging.WarnLevel
+        @test v_standard.non_enclosing_interval isa SciMLLogging.WarnLevel
         @test v_standard.threshold_state isa SciMLLogging.WarnLevel
 
-        @test v_detailed.colorvec_non_sparse isa SciMLLogging.InfoLevel
-        @test v_detailed.non_forward_mode isa SciMLLogging.InfoLevel
-        @test v_detailed.jacobian_free isa SciMLLogging.InfoLevel
+        @test v_detailed.alias_u0_immutable isa SciMLLogging.WarnLevel
+        @test v_detailed.termination_condition isa SciMLLogging.WarnLevel
 
-        @test v_all.colorvec_non_sparse isa SciMLLogging.InfoLevel
+        @test v_all.linsolve_failed_noncurrent isa SciMLLogging.WarnLevel
         @test v_all.threshold_state isa SciMLLogging.InfoLevel
     end
 
     @testset "Group-level keyword constructors" begin
         v_error = NonlinearVerbosity(error_control = SciMLLogging.ErrorLevel())
-        @test v_error.immutable_u0 isa SciMLLogging.ErrorLevel
+        @test v_error.alias_u0_immutable isa SciMLLogging.ErrorLevel
         @test v_error.non_enclosing_interval isa SciMLLogging.ErrorLevel
         @test v_error.termination_condition isa SciMLLogging.ErrorLevel
+        @test v_error.linsolve_failed_noncurrent isa SciMLLogging.ErrorLevel
 
         v_numerical = NonlinearVerbosity(numerical = SciMLLogging.Silent())
         @test v_numerical.threshold_state isa SciMLLogging.Silent
-        @test v_numerical.pinv_undefined isa SciMLLogging.Silent
-
-        v_performance = NonlinearVerbosity(performance = SciMLLogging.InfoLevel())
-        @test v_performance.colorvec_non_sparse isa SciMLLogging.InfoLevel
-        @test v_performance.colorvec_no_prototype isa SciMLLogging.InfoLevel
-        @test v_performance.sparsity_using_jac_prototype isa SciMLLogging.InfoLevel
-        @test v_performance.sparse_matrixcolorings_not_loaded isa SciMLLogging.InfoLevel
     end
 
     @testset "Mixed group and individual settings" begin
         v_mixed = NonlinearVerbosity(
             numerical = SciMLLogging.Silent(),
             threshold_state = SciMLLogging.WarnLevel(),
-            performance = SciMLLogging.InfoLevel()
+            error_control = SciMLLogging.InfoLevel()
         )
         # Individual override should take precedence
         @test v_mixed.threshold_state isa SciMLLogging.WarnLevel
-        # Other numerical options should use group setting
-        @test v_mixed.pinv_undefined isa SciMLLogging.Silent
-        # Performance group setting should apply
-        @test v_mixed.colorvec_non_sparse isa SciMLLogging.InfoLevel
-        @test v_mixed.colorvec_no_prototype isa SciMLLogging.InfoLevel
+        # Error control group setting should apply
+        @test v_mixed.alias_u0_immutable isa SciMLLogging.InfoLevel
+        @test v_mixed.linsolve_failed_noncurrent isa SciMLLogging.InfoLevel
     end
 
     @testset "Individual keyword arguments" begin
         v_individual = NonlinearVerbosity(
-            immutable_u0 = SciMLLogging.ErrorLevel(),
+            alias_u0_immutable = SciMLLogging.ErrorLevel(),
             threshold_state = SciMLLogging.InfoLevel(),
-            colorvec_non_sparse = SciMLLogging.Silent()
+            termination_condition = SciMLLogging.Silent()
         )
-        @test v_individual.immutable_u0 isa SciMLLogging.ErrorLevel
+        @test v_individual.alias_u0_immutable isa SciMLLogging.ErrorLevel
         @test v_individual.threshold_state isa SciMLLogging.InfoLevel
-        @test v_individual.colorvec_non_sparse isa SciMLLogging.Silent
+        @test v_individual.termination_condition isa SciMLLogging.Silent
         # Unspecified options should use defaults
         @test v_individual.non_enclosing_interval isa SciMLLogging.WarnLevel
-        @test v_individual.pinv_undefined isa SciMLLogging.WarnLevel
+        @test v_individual.linsolve_failed_noncurrent isa SciMLLogging.WarnLevel
     end
 
     g(u, p) = u^2 - 4