Skip to content

Commit 90911aa

Browse files
authored
Use secure unity version (CoplayDev#321)
* chore: update Unity version from 2021.3.45f1 to 2021.3.45f2 Older Unity version had the security vulnerability, so we update it * feat: add dynamic version display in editor window settings * refactor: remove manual license file handling from Unity test workflow * Revert "refactor: remove manual license file handling from Unity test workflow" This reverts commit a6ab3d9. * feat: add Unity license credentials to Docker containers in CI workflow * refactor: replace manual Unity license activation with game-ci/unity-activator * refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling * fix: improve Unity license activation in CI by using unityci image's built-in activation flow * refactor: activate once in a temporary container, then reuse the license in the long-running container Now we got the license secret to be read, we got this error: "Machine bindings don't match". So it seems that the license I generated locally can't be used. So we need to activate the license within the container * Revert "refactor: activate once in a temporary container, then reuse the license in the long-running container" This reverts commit f6a9aa6. * Revert "fix: improve Unity license activation in CI by using unityci image's built-in activation flow" This reverts commit a9f4c02. * Revert "refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling" This reverts commit 4e5ffc0. * Revert "refactor: replace manual Unity license activation with game-ci/unity-activator" This reverts commit e9520ee. * Revert "feat: add Unity license credentials to Docker containers in CI workflow" This reverts commit 01b8879.
1 parent 6c00294 commit 90911aa

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

.github/workflows/claude-nl-suite.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ concurrency:
1111
cancel-in-progress: true
1212

1313
env:
14-
UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f1-linux-il2cpp-3
14+
UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f2-linux-il2cpp-3
1515

1616
jobs:
1717
nl-suite:

.github/workflows/unity-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
testMode:
2121
- editmode
2222
unityVersion:
23-
- 2021.3.45f1
23+
- 2021.3.45f2
2424
steps:
2525
# Checkout
2626
- name: Checkout repository

MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ private enum ConnectionProtocol
2424
}
2525

2626
// Settings UI Elements
27+
private Label versionLabel;
2728
private Toggle debugLogsToggle;
2829
private EnumField validationLevelField;
2930
private Label validationDescription;
@@ -191,6 +192,7 @@ private void RefreshAllData()
191192
private void CacheUIElements()
192193
{
193194
// Settings
195+
versionLabel = rootVisualElement.Q<Label>("version-label");
194196
debugLogsToggle = rootVisualElement.Q<Toggle>("debug-logs-toggle");
195197
validationLevelField = rootVisualElement.Q<EnumField>("validation-level");
196198
validationDescription = rootVisualElement.Q<Label>("validation-description");
@@ -240,6 +242,7 @@ private void CacheUIElements()
240242
private void InitializeUI()
241243
{
242244
// Settings Section
245+
versionLabel.text = AssetPathUtility.GetPackageVersion();
243246
debugLogsToggle.value = EditorPrefs.GetBool("MCPForUnity.DebugLogs", false);
244247

245248
validationLevelField.Init(ValidationLevel.Standard);

MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<ui:VisualElement class="section-content">
1010
<ui:VisualElement class="setting-row">
1111
<ui:Label text="Version:" class="setting-label" />
12-
<ui:Label text="5.0.0" name="version-label" class="setting-value" />
12+
<ui:Label text="..." name="version-label" class="setting-value" />
1313
</ui:VisualElement>
1414
<ui:VisualElement class="setting-row">
1515
<ui:Label text="Show Debug Logs:" class="setting-label" />
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
m_EditorVersion: 2021.3.45f1
2-
m_EditorVersionWithRevision: 2021.3.45f1 (0da89fac8e79)
1+
m_EditorVersion: 2021.3.45f2
2+
m_EditorVersionWithRevision: 2021.3.45f2 (88f88f591b2e)

0 commit comments

Comments
 (0)