Tiny flowers + worldedit hangs server startup for 70~ seconds

[Xetaxheb]

Fabric, 1.21.6

[06:04:42] [Server thread/WARN]: Took more than 5 seconds to generate complete state map for tiny-flowers:tiny_garden. This block is likely improperly using properties. State count: 777924. 62986ms elapsed.

For example. Not sure what/if there's a fix, really.

[SecretOnline]

Ahh, this problem. Good to know it's still lingering in the newer versions of the game. It's the one problem with how this mod works, and why Mojang will probably never allow mixing of flower types in the base game. Minecraft needs to know all of the possible combinations of a block up-front, and it turns out that having 20 flower types (plus one more type for empty) in each of 4 spots in 4 rotations is... well... (21 ^ 4) * 4 = 777924. And it'll only get worse as Mojang add more flower types to the game.

Can you try adding FerriteCore to the mod list? A lot of its optimisations deal with multipart blocks, which affects this mod a lot. If that does fix it for you, I'll add a note into the mod description recommending installing it to improve load times. Most of my testing has been on a beefier machine, so I haven't had the same load time issues.

[Xetaxheb]

I assumed as much. The server already has ferritecore and just about every other optimization. I'm not really sure that there is a solution to this since worldedit decides to index all blockstates for its command completion / etc.
I'll attempt raising it with enginehub but I doubt it'll pan out. A note on the page about the issue would be good. It works fine once loaded but the 70s+ to reboot is quite unfortunate...

Just so we're clear that is on a fairly beefy machine. I'd imagine it's even worse without ferritecore or on normal hardware.

[Xetaxheb]

Is there no way to do this with nbt data instead of blockstates?

[SecretOnline]

I'm sure it's possible, but I'm still pretty new to modding and figuring out how to do the rendering of block entities scared me. I knew I'd effectively have to re-implement a good portion of the multipart block rendering, which didn't seem appealing. There already was a perfectly good blockstate system that looked like the right path to go down (and was already in use by the game for pink petals), so I went with that. I'm probably unlikely to change it at this point.

As much as I'd like to say "it's a WorldEdit problem, enumerating all blockstate possibilities on load is an interesting choice", but I'm also to blame here for making a mod that has hundreds of thousands of blockstates for a single block. I'm guessing WorldEdit needs all of the blockstates in order to make all of the command autocompletions, and there isn't going to be much room to budge there.

Unless there is anything else, I'll probably just leave this issue open. If anyone stumbles upon the same issue and wants to have a go at using a block entity instead (including a data fixer for worlds that already have tiny flowers in them), then I'd be more than happy to review it.